Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Simple bug-fix, before the wifi-manager was not requesting credentials; now it does, and now you can successfully connect to any internet connection, I've also fixed the issues with duplicate entries & empty entries when selecting a wifi to connect to.
In this fix I used a temp-file like in the other rewritten util scripts to store the contents of the grabbed wifi-names locally and then remove that file after use; this is a posix compliant approach to bash arrays and unfortunately I do not know any alternatives to storing temp-files, this can be refactored further in the future.
I've also removed the remaining read -s bashisms in this script that weren't removed prior.
Replaced / removed some redundant code as well.
After fixing:
Invalid choice:
Before entry fix:
Before wifi connecting fix:
Entering any number here and then pressing enter would just reload the menu and NOT connect you to a wifi-connection
Testing
tested and worked, verified to see if it connected me to the correct wifi, and it did.
Issue related to PR
Checklist