Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wifi-manager #456

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 18, 2024

Type of Change

  • Bug fix

Description

Simple bug-fix, before the wifi-manager was not requesting credentials; now it does, and now you can successfully connect to any internet connection, I've also fixed the issues with duplicate entries & empty entries when selecting a wifi to connect to.

In this fix I used a temp-file like in the other rewritten util scripts to store the contents of the grabbed wifi-names locally and then remove that file after use; this is a posix compliant approach to bash arrays and unfortunately I do not know any alternatives to storing temp-files, this can be refactored further in the future.

I've also removed the remaining read -s bashisms in this script that weren't removed prior.

Replaced / removed some redundant code as well.

After fixing:
image
Invalid choice:
image
Before entry fix:
image
image
image
Before wifi connecting fix:
image
Entering any number here and then pressing enter would just reload the menu and NOT connect you to a wifi-connection

Testing

tested and worked, verified to see if it connected me to the correct wifi, and it did.

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 18, 2024
@ChrisTitusTech ChrisTitusTech merged commit 69b61e7 into ChrisTitusTech:main Sep 18, 2024
7 checks passed
@nnyyxxxx nnyyxxxx deleted the fixwifimanager branch September 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wifi-manager fails to request password due to bashisms and incorrect listing.
3 participants