Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bashism in docker-setup #476

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove bashism in docker-setup #476

merged 1 commit into from
Sep 19, 2024

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 18, 2024 •
edited
Loading

Type of Change

  • Bug fix

ALL BASHISMS WILL BE FIXED AFTER MERGING MY PRs

Description

title

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx
Copy link
Contributor Author

No bashisms exist in the diff, only in the other scripts in the repository, im making PRs to clean these up! ❤️

@nnyyxxxx nnyyxxxx changed the title Fix bashism in docker-setup Remove bashism in docker-setup Sep 18, 2024
@ChrisTitusTech ChrisTitusTech merged commit 1175f7d into ChrisTitusTech:main Sep 19, 2024
1 check failed
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
@nnyyxxxx nnyyxxxx deleted the fixbashismindockersetup branch September 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamperkowski adamperkowski adamperkowski approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnyyxxxx @ChrisTitusTech @adamperkowski