Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 again #496

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 19, 2024

Type of Change

  • I don't really know what type of change is this. I just added the aarch64 in CI and it works.

Description

  • Added aarch64 in workflow

Testing

  • Tested on linutil fork and runs without errors.

Issues / other PRs related

Additional Information

  • I took a look at the old errors of aarch64 build. I encounter similar errors when switching from my arch system to ubuntu20 testing system sometimes. Doing a cargo clean and re-building would resolve the errors. I am not sure whether these two issues are related. For now aarch64 has no errors. In case we encounter such errors in future we can fix them.
  • The error happens when half of the cargo.lock gets build on newer glibc and the other half gets build on older glibc.
  • cargo clean would clear all the old built crate binaries and will build again from the start so there would no conflicts.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on hardware & emulated ARM64. Works like a charm.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ChrisTitusTech ChrisTitusTech merged commit fa5ff19 into ChrisTitusTech:main Sep 19, 2024
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
@jeevithakannan2 jeevithakannan2 deleted the aarch64 branch September 20, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants