Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant functionality #520

Merged

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 19, 2024

Type of Change

  • Refactoring

Description

Removes the unnecessary functionality: "install_additional_dependencies" the packages that would get added to that can just be added to the function above it "installDepend" making this functionality unneeded

Also this functionality is really outdated as seen with the structure of it and it not relying on PACKAGER from common-script

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit 2755c0d into ChrisTitusTech:main Sep 19, 2024
1 check passed
@nnyyxxxx nnyyxxxx deleted the removeunnecessaryfunctionality branch September 19, 2024 17:22
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants