Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing nala #544

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix: Add missing nala #544

merged 4 commits into from
Sep 20, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • Bug fix

Description

  • Added missing nala in scripts

Testing

  • Tested on debian12 works fine

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2 jeevithakannan2 mentioned this pull request Sep 19, 2024
Closed
adamperkowski
adamperkowski reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be quoted. Include unquoting in this PR pls.

linutil/tabs/system-setup/5-samba-ssh-setup.sh

Lines 29 to 33 in 93ac106

"apt-get|nala")
install_package openssh-server
SSH_SERVICE="ssh"
;;
"pacman")

@jeevithakannan2
Copy link
Contributor Author

These shouldn't be quoted. Include unquoting in this PR pls.

linutil/tabs/system-setup/5-samba-ssh-setup.sh

Lines 29 to 33 in 93ac106

"apt-get|nala")
install_package openssh-server
SSH_SERVICE="ssh"
;;
"pacman")

Yup sorry didn't notice it was there !!

adamperkowski
adamperkowski approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ChrisTitusTech
ChrisTitusTech approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update with new merges as we changed file names

@jeevithakannan2
Copy link
Contributor Author

@ChrisTitusTech Ready for merge !!!

@ChrisTitusTech ChrisTitusTech merged commit f46d313 into ChrisTitusTech:main Sep 20, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the missing-nala branch September 21, 2024 00:58
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamperkowski adamperkowski adamperkowski approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker not installing
3 participants
@jeevithakannan2 @ChrisTitusTech @adamperkowski