Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "valids user" argument in share section #558

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Adding "valids user" argument in share section #558

merged 1 commit into from
Sep 20, 2024

Conversation

dhruvmistry2000
Copy link
Contributor

@dhruvmistry2000 dhruvmistry2000 commented Sep 20, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Testing

Impact

Issues / other PRs related

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@dhruvmistry2000
Copy link
Contributor Author

I used the samba setup it was not entering the valid user argument in the share section and because of that it was not being accessed

nnyyxxxx
nnyyxxxx approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ChrisTitusTech ChrisTitusTech merged commit b10dfa4 into ChrisTitusTech:main Sep 20, 2024
2 checks passed
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhruvmistry2000 @ChrisTitusTech @adamperkowski @nnyyxxxx