Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: printer driver installation #837

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Vorthas
Copy link
Contributor

@Vorthas Vorthas commented Oct 15, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Came to mind to add this when I was struggling to get my Epson printer working earlier today on my new computer. Turns out I forgot to install the Epson printer drivers in the AUR. I did a search and the same package is in the Debian and Fedora repos so I added support for those, but I'm not really able to test them myself as I only use EndeavourOS. I can comment those out in the shell script if needed.

Testing

Ran the script and verified it installed (or reinstalled in my case) the correct drivers and saw them show up in CUPS when I brought up the CUPS web interface.

Impact

Printer driver installation on Linux (and on Windows for that matter) is a real pain to get right sometimes, I'm hoping this will help people out who use Epson printers.

Issues / other PRs related

N/A

Additional Information

As I mentioned in description, I only really tested this on an Arch-based distro. May need some help testing this on a Debian- or Fedora-based distro.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Vorthas Vorthas changed the title Add Epson inkjet printer driver installation and printer category under Utilities Feat: Add Epson inkjet printer driver installation and printer category under Utilities Oct 15, 2024
@adamperkowski adamperkowski added the enhancement New feature or request label Oct 25, 2024
@adamperkowski adamperkowski changed the title Feat: Add Epson inkjet printer driver installation and printer category under Utilities feat: printer driver installation Oct 25, 2024
@adamperkowski
Copy link
Collaborator

I don't know about this...

@adamperkowski
Copy link
Collaborator

Should probably install cups

@Vorthas
Copy link
Contributor Author

Vorthas commented Oct 25, 2024

Think CUPS installation should be done in a separate script that this script calls? Since I'd imagine most printer drivers for Linux would need CUPS as a dependency.

… as well as standalone script for other printer drivers to be added in the future.
@adamperkowski
Copy link
Collaborator

Think CUPS installation should be done in a separate script that this script calls?

Yeah would be a good idea to have cups.sh

core/tabs/utils/printers/install-cups.sh Outdated Show resolved Hide resolved
core/tabs/utils/printers/install-epson-printer-drivers.sh Outdated Show resolved Hide resolved
core/tabs/utils/tab_data.toml Outdated Show resolved Hide resolved
core/tabs/utils/tab_data.toml Outdated Show resolved Hide resolved
Vorthas and others added 5 commits October 30, 2024 20:27
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants