Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gaming-setup.sh #380

Merged

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Sep 14, 2024

Type of Change

  • Refactoring

Description

Refactored the gaming setup script to have more synergy with other scripts, removed bashisms, updated dep list and added new features (for package managers).

Impact

  • revieved all packages
  • changed the structure to have synergy with other scripts
  • updated dnf & zypper commands
  • added nala

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

 - revieved all packages
 - changed the structure to have synergy with other scripts
 - updated dnf & zypper commands
 - added nala
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

adamperkowski and others added 2 commits September 17, 2024 13:45
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
Co-authored-by: nnyyxxxx <nnyyxxxx@users.noreply.github.com>
@adamperkowski
Copy link
Collaborator Author

Not sure what's up with the CI here.

@ChrisTitusTech ChrisTitusTech merged commit 44d9360 into ChrisTitusTech:main Sep 18, 2024
1 check failed
@adamperkowski adamperkowski deleted the gaming_setup_refactor branch September 18, 2024 20:16
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants