-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dwm-Titus-Setup] add slstatus installation option #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiles and Installs slstatus
nnyyxxxx
reviewed
Sep 15, 2024
nnyyxxxx
reviewed
Sep 15, 2024
I hope i did correct change @nnyyxxxx , i didn't reset last commit because it was pushed. |
nnyyxxxx
reviewed
Sep 15, 2024
RazoBeckett
force-pushed
the
fix/slstatus
branch
from
September 15, 2024 13:56
f63167e
to
3026b75
Compare
i am so sorry @nnyyxxxx i have never done this before i am still learning Github. |
nnyyxxxx
reviewed
Sep 15, 2024
nnyyxxxx
reviewed
Sep 15, 2024
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
using `$HOME` rather than `cd ..` Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
nnyyxxxx
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the time of reviewing.
ChrisTitusTech
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
[Dwm-Titus-Setup] add slstatus installation option
Type of Change
Description
This PR introduces a new function to optionally install
slstatus
during the DWM setup process. It prompts the user for confirmation and handles different responses (yes/no). Additionally, it ensures proper directory navigation and error handling during the installation process using the system's escalation tool. This change enhances the flexibility of the DWM setup script by allowing users to choose whether or not to installslstatus
.Issue related to PR
Additional Information
Provide any suggestion if required changes.
Checklist