Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dwm-Titus-Setup] add slstatus installation option #392

Merged
merged 5 commits into from
Sep 15, 2024

Conversation

RazoBeckett
Copy link
Contributor

@RazoBeckett RazoBeckett commented Sep 15, 2024

Pull Request

Title

[Dwm-Titus-Setup] add slstatus installation option

Type of Change

  • New feature
  • Bug fix
  • Hotfix

Description

This PR introduces a new function to optionally install slstatus during the DWM setup process. It prompts the user for confirmation and handles different responses (yes/no). Additionally, it ensures proper directory navigation and error handling during the installation process using the system's escalation tool. This change enhances the flexibility of the DWM setup script by allowing users to choose whether or not to install slstatus.

Issue related to PR

Additional Information

Provide any suggestion if required changes.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@RazoBeckett
Copy link
Contributor Author

RazoBeckett commented Sep 15, 2024

I hope i did correct change @nnyyxxxx , i didn't reset last commit because it was pushed.

@RazoBeckett
Copy link
Contributor Author

i am so sorry @nnyyxxxx i have never done this before i am still learning Github.

RazoBeckett and others added 2 commits September 15, 2024 14:11
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
using `$HOME` rather than `cd ..`

Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at the time of reviewing.

@ChrisTitusTech ChrisTitusTech merged commit 182f0a4 into ChrisTitusTech:main Sep 15, 2024
1 check passed
@RazoBeckett RazoBeckett deleted the fix/slstatus branch September 18, 2024 14:08
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slstatus not autostarting
3 participants