Language tweaking #90
Conversation
Removing unnecessary exclamation marks and rephrasing a few immersion-breaking lines.
Making the text even with English translation and fixing mistakes.
| </string> | ||
| <string id="st_tm_guide_213"> | ||
| <text>Whoops, I can’t afford this.</text> | ||
| <text>Seems like I can’t afford this.</text> |
There was a problem hiding this comment.
Not a fan of this change; it fails to convey the surprise of the original.
Context: From what I remember, this dialog is a work-around for a bug in the vanilla game that enables the player to select a fast-travel point, break out of the dialog, go spend some money, re-enter the dialog, and re-select the travel point even if it can no longer be afforded.
The dialog is meant to purport that the player has mistakenly selected the unaffordable travel point, even though it's actually the game's programming that has mistakenly made it possible to re-select.
I don't think the original dialog needs changing, but if you must, a better replacement dialog would be:
My mistake - I can’t afford this.
There was a problem hiding this comment.
I don't really know is these things existed in English localization, but in Russian 'Whoops' sounded just wrong for a man like Scar. Most of his dialogues leave an impression of a man in his fourties with an always straight face. Probably just my portrait of him and I might be wrong, but there's never something like 'Whoops' in the original game. I recall we discussed this in Steam chats, and you did not oppose this change back then.
My mistake - I can’t afford this.
Yeah, I like that compromise as well. It’s something that’s kinda in-between.
| </string> | ||
| <string id="tips_wait_emission_finish"> | ||
| <text>You must wait for the emission to finish.</text> | ||
| <text>It's not safe to travel during the emission.</text> |
There was a problem hiding this comment.
' should be replaced by ’ to be consistent with the style followed in the SRP. With that said, I don't actually remember why I globally replaced the former with the latter in the English texts. It may have been an attempt to fix this bug.
| </string> | ||
| <string id="gar_bandit_robbery_112"> | ||
| <text>I don’t think so.</text> | ||
| <text>I don’t think so.</text> |
There was a problem hiding this comment.
There should not be a diff on this line. Your text editor seems to have re-encoded the UTF-8 file as Windows-1252 and replaced ’ (U+2019) (E2 80 99) with ’ (D0 B2 D0 82 E2 84 A2).
|
|
||
| <string id="yan_levshas_crew"> | ||
| <text>Lefty’s crew member</text> | ||
| <text>Lefty’s crew member</text> |
There was a problem hiding this comment.
|
A general remark: any changes to eng\srp_strings.xml should be copied/translated to other localizations' srp_strings.xml. That means eng\srp_strings.xml will need to be copied to {cz, fra, ger, hg, ita, pol, spa}\srp_strings.xml. But please don't do that until we're both satisfied with the state of eng\srp_strings.xml - I've highlighted some issues that need addressing, above. Also, any changes to eng\srp_strings.xml will need to be copied to |
|
The end of line difference is made by GitHub Web Editor, as I stated in the other pull request. Probably downloading, making changes locally and uploading it will work this issue around. I'll test it. |
c6077bf to
7d89f09
Compare
A few fixes and changes to Russian and English text files.