(Gsoc'21)🔨Fixes a bug in reverb.js,added it to test list

Devesh21700Kumar · Jul 22, 2021 · 99f3eb2 · 99f3eb2
1 parent ff5d4c9
commit 99f3eb2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/reverb.js b/src/reverb.js
@@ -103,20 +103,7 @@ class Reverb extends Effect {
    */
   process(src, seconds, decayRate, reverse) {
     src.connect(this.input);
-    var rebuild = false;
-    if (seconds) {
-      this._seconds = seconds;
-      rebuild = true;
-    }
-    if (decayRate) {
-      this._decay = decayRate;
-    }
-    if (reverse) {
-      this._reverse = reverse;
-    }
-    if (rebuild) {
-      this._buildImpulse();
-    }
+    this.set(seconds, decayRate, reverse);
   }
 
   /**

diff --git a/test/tests.js b/test/tests.js
@@ -27,4 +27,5 @@ import('./tests/p5.Noise.js');
 import('./tests/p5.Panner.js');
 import('./tests/p5.Panner3d.js');
 import('./tests/p5.Delay.js');
+import('./tests/p5.Reverb.js');
 import('./tests/p5.Listener3d.js');