Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ole #1659

Merged
merged 34 commits into from
Nov 18, 2024
Merged

Feature/ole #1659

merged 34 commits into from
Nov 18, 2024

Conversation

AdrianEPPlus
Copy link
Contributor

Support for OLE Objects.

Before submitting this pull request I have...

  • read EPPlus Softwares Contribution Guidlines
  • ensured that the functionality I have added/changed is covered by new unit tests.
  • merged the target branch into the PR branch and resolved any merge conflicts
  • Run all the unit tests and ensured that they all are green (unless the purpose of the PR is to provide us with failing unit tests).

AdrianEPPlus and others added 30 commits October 8, 2024 13:18
@AdrianEPPlus
Delete method for ole objects.
eaa5c6f
@JanKallman
Update Microsoft.Extensions.Configuration.Json to 8.0.1 - #1623
30117b9
@JanKallman @swmal
Feature/new default font (#1621)
860a2e0 
* Tests for new default font

* wip

* Added scale factors for Aptos Display and Aptos Narrow

* Updated test project file

* Removed invalid test

---------

Co-authored-by: swmal <897655+swmal@users.noreply.github.com>
@JanKallman
EPPlus version 7.4.1
b7f9fbd
@JanKallman
Removed fixed references
d0c4d16
@JanKallman
Added version information in history list
4ace85f
@AdrianEPPlus
Copy ole object and tests
ce05b0d
@swmal
#1624 - fix for preserving rich data on save (#1625)
e56aff6 
* #1624 - fix for preserving rich data on save

* Removed uncommented code

---------

Co-authored-by: swmal <{ID}+username}@users.noreply.github.com>
@AdrianEPPlus
Fixed some issues with copy ole object.
038f398
@AdrianEPPlus
Copy ole object complete.
0638122
@AdrianEPPlus
Fixed issue with opening ms office documents.
53d0238
@AdrianEPPlus
Fixed issue opening copes of ms office docs.
30f7506
@AdrianEPPlus
Uisng Picture store for ole emf images
c50d53c
@AdrianEPPlus
Copying ole objects through worksheet copy
ecf2fbb
@AdrianEPPlus
ole worksheet copy progress
77b9423
@OssianEPPlus
Bug/i1626 (#1636)
997b157 
* Added fix for #1626

* Ensured two-anchor and other images are copied properly

* Added fixed issues
@OssianEPPlus
Added minor feature for #1632 (#1637)
92fdac5
@OssianEPPlus
Bug/s745 (#1644)
09dfc27 
* Located one problem area

* Added comparisons and fixed incorrect flags

* Added fixed issues
@AdrianEPPlus
Fixed some issues with linked ole objects and finished worksheet copy.
e6ef474
@JanKallman
Fixes issue #1645 (#1648)
7aa5021
@JanKallman
Fixes issue #1646 (#1647)
90de83f
@OssianEPPlus
Added fix for #1628. Corrected ids on deleting tables (#1634)
acd83ad 
modified:   EPPlusTest/Issues/LegacyTests/Issues.cs
@OssianEPPlus
Bug/i1631 Row/ColumnOffsets (#1633)
429f2f2 
* Fix for #1631 column/row offset in shared formulas

* Added fixed issues note

* add testmethod
@AdrianEPPlus
added Ole Object xml comments, stream, fileinfo, name, arg object
740fc54
@AdrianEPPlus
Stream and fileinfo tests.
d9902ee
@JanKallman
Fixes array formula calculation for single cells containing range ope…
6629fbf 
…rations (#1657)

* Fixes array formula calculation for single cell arrays. #1649

* Range operations using conditional operators are now identified as dynamic array formulas

* Replaced ApplyWithDynamicResult method with Apply

* Minor changes to Update of table array property
@JanKallman
Fixed issue #1653 and enabled update of the Workbook.MaxFontWidth pro…
7a56a79 
…perty. (#1654)
@JanKallman
EPPlus version 7.4.2
46a4ace
@AdrianEPPlus
Many small changes.
15d44bd
@AdrianEPPlus
Fixed some tests
1af6866
@AdrianEPPlus AdrianEPPlus added the enhancement New feature or request label Oct 29, 2024
@AdrianEPPlus AdrianEPPlus self-assigned this Oct 29, 2024
@AdrianEPPlus
Merge branch 'develop7' into feature/ole
c606f68 
# Conflicts:
#	src/EPPlus/Core/Worksheet/WorksheetCopyHelper.cs
@AdrianEPPlus
Merge branch 'develop8' into feature/ole
09160f2 
# Conflicts:
#	src/EPPlus/Core/Worksheet/Fonts/FontMetricsFamilies.cs
#	src/EPPlus/Core/Worksheet/WorksheetCopyHelper.cs
#	src/EPPlus/Drawing/EMF/EmfCalculateTextLength.cs
#	src/EPPlus/Drawing/EMF/EmfImage.cs
#	src/EPPlus/Drawing/EMF/Records/EMR_EXTTEXTOUTW.cs
#	src/EPPlus/Drawing/EMF/Records/EMR_SELECTOBJECT.cs
#	src/EPPlus/resources/TextMetrics.zip
#	src/EPPlusTest/EmfTest.cs
#	src/EPPlusTest/Table/TableTests.cs
@AdrianEPPlus
Fixed errors and fixed correct TextMetrics
0f71844
This was linked to issues Oct 29, 2024
OLE Object support #1605
Closed
Copying a sheet containing an OLEObject corrupts the workbook #360
Open
@JanKallman JanKallman merged commit b9d4556 into develop8 Nov 18, 2024
@JanKallman JanKallman deleted the feature/ole branch November 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swmal swmal Awaiting requested review from swmal

@JanKallman JanKallman Awaiting requested review from JanKallman

@OssianEPPlus OssianEPPlus Awaiting requested review from OssianEPPlus

Assignees

@AdrianEPPlus AdrianEPPlus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copying a sheet containing an OLEObject corrupts the workbook OLE Object support
4 participants
@AdrianEPPlus @JanKallman @swmal @OssianEPPlus