This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 384
Only mark new features as fetched after call goes through #2713
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Only mark new features as fetched after call goes through
- Loading branch information
commit b5469386e76fa89797ba07430af350b04b5bc082
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,17 +64,25 @@ final class NewFeaturesController { | |
guard let url = fetchURL, | ||
(testing == true || hasFetchedLatest == false) | ||
else { return } | ||
hasFetchedLatest = true | ||
|
||
let task = session.dataTask(with: url) { (data, response, _) in | ||
if let response = response as? HTTPURLResponse, | ||
response.statusCode == 200, | ||
let data = data, | ||
let string = String(data: data, encoding: .utf8) { | ||
DispatchQueue.main.async { [weak self] in | ||
self?.latestMarkdown = string | ||
success() | ||
} | ||
let task = session.dataTask(with: url) { data, response, error in | ||
guard | ||
let httpResponse = response as? HTTPURLResponse, | ||
[200, 404].contains(httpResponse.statusCode), | ||
let data = data else { | ||
let message = """ | ||
"Expected a successfull or failing status code, but errored | ||
with \(error?.localizedDescription ?? "no error") for | ||
\(response?.description ?? "no response") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean |
||
""" | ||
return assertionFailure(message) | ||
} | ||
let string = String(decoding: data, as: UTF8.self) | ||
DispatchQueue.main.async { [weak self] in | ||
guard let strongSelf = self else { return } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: I think there is no need to write |
||
strongSelf.hasFetchedLatest = true | ||
strongSelf.latestMarkdown = string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not? strongSelf.latestMarkdown = String(decoding: data, as: UTF8.self) |
||
success() | ||
} | ||
} | ||
task.resume() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need to take into consideration
404
. If the status is404
and rest of the guard passes, means thathasFetchedLatest
will betrue
. Which, in IMO, shouldn't be. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to care only about this range
200..<300
.