This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Fix #2769 #2770
Merged
Fix #2769 #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisho
reviewed
Jun 6, 2019
| @@ -81,6 +81,14 @@ final class NotificationSectionController: ListSwiftSectionController<Notificati | |||
|
|
|||
| BadgeNotifications.clear(for: model) | |||
|
|
|||
| if model.type == .securityVulnerability { | |||
There was a problem hiding this comment.
This seems like a good case for a guard 😄
There was a problem hiding this comment.
Sure thing :))
jdisho
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
Awesome! Thank you @LucianoPAlmeida 😄
(I will leave the PR open for now in case someone else wants to have a look)
|
Awesome, thanks @LucianoPAlmeida (and for reviewing/merging, @jdisho)! |
|
Shouldn’t this open the URL of the vulnerability in a Safari View Controller so the user can view the report itself? |
|
@j-f1 that's a good point 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2769
so from:
to: