-
Notifications
You must be signed in to change notification settings - Fork 384
Fix #2769 #2770
Fix #2769 #2770
Conversation
@@ -81,6 +81,14 @@ final class NotificationSectionController: ListSwiftSectionController<Notificati | |||
|
|||
BadgeNotifications.clear(for: model) | |||
|
|||
if model.type == .securityVulnerability { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good case for a guard
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you @LucianoPAlmeida 😄
(I will leave the PR open for now in case someone else wants to have a look)
Awesome, thanks @LucianoPAlmeida (and for reviewing/merging, @jdisho)! |
Shouldn’t this open the URL of the vulnerability in a Safari View Controller so the user can view the report itself? |
@j-f1 that's a good point 👍 |
Fix #2769
so from:
to: