Skip to content

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 11, 2025

Check if the change conflicts with neo4j test

Reverts #2624

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (a36f899) to head (c2228ad).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2636      +/-   ##
============================================
+ Coverage     49.81%   49.83%   +0.02%     
- Complexity     4893     5246     +353     
============================================
  Files           954      954              
  Lines         58448    58411      -37     
  Branches       6329     6320       -9     
============================================
- Hits          29113    29110       -3     
+ Misses        27255    27218      -37     
- Partials       2080     2083       +3     
Components Coverage Δ
spanner-templates 70.02% <ø> (-0.02%) ⬇️
spanner-import-export 68.61% <ø> (-0.04%) ⬇️
spanner-live-forward-migration 79.12% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 88.09% <ø> (ø)
Files with missing lines Coverage Δ
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn Abacn marked this pull request as ready for review August 11, 2025 20:03
@Abacn
Copy link
Contributor Author

Abacn commented Aug 11, 2025

It appears this change conflicts with neo4j test container. Reason is unknown.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 11, 2025

cc: @shunping @damccorm

Going to merging this as this exactly reverts the latest commit, in order to to unblock upcoming release

@Abacn Abacn merged commit 5ecb94b into main Aug 11, 2025
46 of 49 checks passed
@Abacn Abacn deleted the revert-2624-cleanup-test branch August 11, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants