feat: separate op for maintenanceVersion #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf5954c to
7f6f64d
Compare
yuwenma
reviewed
Jul 23, 2025
...ure/testdata/basic/sql/v1beta1/sqlinstance/sqlinstance-maintenanceversion-direct/create.yaml
Outdated
Show resolved
Hide resolved
yuwenma
reviewed
Jul 29, 2025
...ure/testdata/basic/sql/v1beta1/sqlinstance/sqlinstance-maintenanceversion-direct/update.yaml
Show resolved
Hide resolved
acpana
commented
Jul 29, 2025
...ure/testdata/basic/sql/v1beta1/sqlinstance/sqlinstance-maintenanceversion-direct/create.yaml
Outdated
Show resolved
Hide resolved
acpana
commented
Jul 29, 2025
...ure/testdata/basic/sql/v1beta1/sqlinstance/sqlinstance-maintenanceversion-direct/update.yaml
Show resolved
Hide resolved
401f26c to
4544723
Compare
|
/lgtm |
justinsb
reviewed
Aug 6, 2025
| if body.MaintenanceVersion != "" { | ||
| obj.MaintenanceVersion = body.MaintenanceVersion | ||
| } | ||
| // todo kcc team: refactor this all so we can pass in specific values for database settings |
There was a problem hiding this comment.
Can you also tweak the mock so that it exhibits the behaviour we got wrong?
Ideally we would have
- commit adding test or enhancing existing test (including GCP log, fine to split that into another commit - I would probably create a separate commit if it's a separate test, but if you can reuse an existing test so it's more like a 10 line diff I would keep them in the same commit)
- commit adding mockgcp behaviour (so test now fails)
- commit fixing controller
- commit updating golden output with fixed controller
There was a problem hiding this comment.
restructured the commits according to this suggestion 🙏🏼
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
17b2212 to
3eab59b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: separate op for maintenanceVersion for SQLInstance
Note the error without the patch on the controller:
Does this PR add something which needs to be 'release noted'?