-
Notifications
You must be signed in to change notification settings - Fork 291
chore: refactor ComputeNetworkRef #5201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: refactor ComputeNetworkRef #5201
Conversation
761214d
to
8b05f90
Compare
There's no untested ComputeNetwork references in direct resources(source). There's no golden logs changed post-refactoring confirm that direct resources won't be affected by this PR. |
8b05f90
to
8e75a0c
Compare
8e75a0c
to
eebc340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @cheftako
eebc340
to
72a6b08
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
72a6b08
to
01d7464
Compare
01d7464
to
68bd1d5
Compare
Generated code review:
|
To address Gemini code review suggestion, added unit test for the NormalizedExternal function in ff83de2 This ensured that both formats(full and partial url) are accepted and normalized to the standard external format. |
e9fd7e7
to
94b8128
Compare
Change description
Move refs from apis/refs/v1beta1 to apis/compute/v1beta1 and use NormalizedExternal to resolve its value
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-pr
to ensure this PR is ready for review.