-
Notifications
You must be signed in to change notification settings - Fork 291
chore: update license scan dependency #5374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
```bash | ||
|
||
cp -r -n modules/* experiments/tools/licensescan/modules/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to delete the old licenses? They are both valuable in terms of building up a database, but also the diffs get messed up if we don't keep them (as has happened here)
# https://pkg.go.dev/cloud.google.com/go/bigtable@v1.19.0 | ||
license: Apache-2.0 | ||
# https://pkg.go.dev/cloud.google.com/go/firestore@v1.19.0 | ||
license: TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO?
BRIEF Change description
Update license dependency
WHY do we need this change?
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-pr
to ensure this PR is ready for review.