Added installation instructions for public hosting to readme #715
Conversation
Added "Installation on public server"
|
|
|
Thank you for this! I'll do a quick test and merge. We may need to put it in a separate document and link to it from the README... |
Set config.registration_closed=true; in ./src/backend/src/config.js to close registration
I'm glad you like it. What about a wiki for documentation? |
src/backend/src/routers/signup.js
Outdated
| { | ||
| return res.status(403).send('Registration is closed.'); | ||
| } | ||
| else |
There was a problem hiding this comment.
We don't need an else if there's an early return. Removing this will reduce indentation changes and make the PR easier to review.
|
We have some documentation for this under Self-Hosting instructions but we don't have this linked in the README.md file anymore. If you have the time it would be nice to cross-reference what you wrote and what's already there and try to pick the best from both. Ideally all documentation for this should be in |
Sure, no problem. |
Thanks, diff looks much better now! We'll be able to merge the signup change quicker than the README.md update, but I don't want you to lose credit from us cherry-picking it so if you have time to make a separate PR for it that might be better (sorry about all the git chores btw, I should've brought that up yesterday) |
Added installation instructions for public hosting to readme