Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casks with Sparkle/Electron and no auto_update #170994

Open
krehel opened this issue Apr 9, 2024 · 8 comments
Open

Casks with Sparkle/Electron and no auto_update #170994

krehel opened this issue Apr 9, 2024 · 8 comments
Labels
help wanted

Comments

@krehel
Copy link
Member

krehel commented Apr 9, 2024 •
edited by khipp
Loading

Applications that use Sparkle or Electron typically have their updates managed automatically through a feed and can update outside of Homebrew. At some point, the Casks below were added to Homebrew but are not marked as having automatic updates.

Accordingly, below is the list of Casks that are using either :sparkle or :electron_builder as a livecheck strategy, but do not have auto_updates true.

The ask for each app would be as follows -

  1. Verify the livecheck information is correct and does return the latest version, verified by another means than the livecheck.
  2. If the information is not correct, please update the livecheck to appropriately return the version information. That can be through :sparkle or :electron_builder, or another means if those are not returning the proper information.
  3. Verify if the application should have auto_update true, and if so then please add it and open a PR. If a screenshot can be captured showing the automatic update feature and added to the PR, that would be a great addition.
  4. Please update any other aspects of the Cask that may be outdated, especially if multiple versions behind current.
  5. Please link the PR beside the Cask name in this issue, or comment with the PR and a maintainer can update this list.
  6. If it should not have auto_update true and requires no additional changes, then please check it off this list or mention in comment.
  7. If the Cask is no longer offered, is moved to the Mac App Store, or is otherwise no longer developed, please open a PR to mark as deprecated for Homebrew Maintainers to consider.
  8. If you need help, please feel free to mention me here or in a PR.
@krehel krehel changed the title [Task | Help Wanted] - Casks with Sparkle/Electron and no auto_update [Task | Help Wanted] Casks with Sparkle/Electron and no auto_update Apr 10, 2024
@SMillerDev
Copy link
Member

Should we have an audit for this? It seems easy to check this programmatically

@bevanjkay
Copy link
Member

It seems like a reasonable idea. It depends if there are any scenarios where the auto update mechanism doesnt work despite there being a feed available.

@SMillerDev
Copy link
Member

We can always make an allowlist

@SMillerDev SMillerDev changed the title [Task | Help Wanted] Casks with Sparkle/Electron and no auto_update Casks with Sparkle/Electron and no auto_update Apr 10, 2024
@krehel
Copy link
Member Author

krehel commented Apr 10, 2024

That's probably the way to go re: allowlist

I have seen -some- Casks (don't recall which) that use Electron but not the auto-update feature. I don't believe I've seen any that use Sparkle and don't auto-update.

@swrobel
Copy link
Contributor

swrobel commented Jun 7, 2024

#176008

@piijai piijai mentioned this issue Jul 13, 2024
Merged
8 tasks
@piijai
Copy link
Contributor

piijai commented Jul 13, 2024

#179498

@piijai piijai mentioned this issue Aug 28, 2024
Merged
8 tasks
@piijai
Copy link
Contributor

piijai commented Aug 28, 2024

I have checked Casks/i/ilok-license-manager.rb:

  • Livecheck returns the latest version.
  • iLok License Manager has a setting to activate check for updates, but it does not automatically install updates.

So far, no changes needed.

Screenshot:
auto-update-ilok-license-manager

This was referenced Sep 3, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@tshu-w

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@swrobel @SMillerDev @piijai @tshu-w @krehel @bevanjkay