Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various [i] casks: add rosetta caveat #179654

Merged
merged 40 commits into from
Jul 17, 2024
Merged

various [i] casks: add rosetta caveat #179654

merged 40 commits into from
Jul 17, 2024

Conversation

krehel
Copy link
Member

@krehel krehel commented Jul 16, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

krehel added 15 commits July 15, 2024 23:22
@krehel
ibackupbot: add rosetta caveat
6428c18 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ibettercharge: add rosetta caveat
b2039b0 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ibored: add rosetta caveat
244a50d 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
icanhazshortcut: add rosetta caveat
a21be76 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
icloud-control: add rosetta caveat
da76dfd 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
icons8: add rosetta caveat
8b7cc7a 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iconscout: add rosetta caveat
0d218c0 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ieasemusic: add rosetta caveat, deprecate
d7abcbc 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iexplorer: add rosetta caveat
cde2227 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
igdm: add rosetta caveat
71c7813 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iglance: add rosetta caveat
6a7ef74 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
igv: add rosetta caveat
ac9189c 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
imagex: add rosetta caveat
403c983 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
imgotv: add rosetta caveat
856db53 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
inav-configurator: add rosetta caveat
771df9c 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@bevanjkay
Copy link
Member

@krehel Looks like ipsecuritas and infinity need to be dropped, and then we could go syntax-only.

@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

Thanks - I'll tackle this when I get back to a laptop.

krehel added 12 commits July 16, 2024 14:44
@krehel
inssider: add rosetta caveat
49d877c 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
instatus-out: add rosetta caveat
2bface3 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
internxt-drive: add rosetta caveat
1e628ef 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
invesalius: add rosetta caveat
1323dfe 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
invisiblix: add rosetta caveat
b4e958b 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
invisionsync: add rosetta caveat
7610dea 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
invisor-lite: add rosetta caveat
57af942 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ipa-manager: add rosetta caveat
9876f3e 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ipartition: add rosetta caveat
7c41411 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iphoto-library-manager: add rosetta caveat
263f301 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
ipremoteutility: add rosetta caveat
4d2836f 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iqmol: add rosetta caveat
96c231e 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
iris: add rosetta caveat
f69e048 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
islide: add rosetta caveat
c06fed6 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
istat-menus@5: add rosetta caveat
a958189 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel
istat-server: add rosetta caveat
7ac23c3 
Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@krehel krehel force-pushed the various-add-rosetta-caveat-i branch from cd72ed6 to 7ac23c3 Compare July 16, 2024 18:45
@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

audit for imgotv: failed

  • Version '6.4.16' differs from '' retrieved by livecheck.

@krehel krehel added ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. labels Jul 16, 2024
khipp
khipp reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I went through the homepages and left some suggestions. By the looks of it, we could deprecate some of the casks. 😄

Casks/i/iphoto-library-manager.rb Outdated Show resolved Hide resolved
Casks/i/ipa-manager.rb Outdated Show resolved Hide resolved
Casks/i/internxt-drive.rb Outdated Show resolved Hide resolved
Casks/i/invesalius.rb Outdated Show resolved Hide resolved
Casks/i/invisiblix.rb Outdated Show resolved Hide resolved
Casks/i/iglance.rb Outdated Show resolved Hide resolved
Casks/i/icloud-control.rb Outdated Show resolved Hide resolved
Casks/i/icons8.rb Outdated Show resolved Hide resolved
Casks/i/igv.rb Outdated Show resolved Hide resolved
@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

Feel free to push some updates! 😀 I'm batching into Rosetta, deprecate, and disable usually but I don't check every Cask repo or homepage. I plan to after I work through the Rosetta work.

@p-linnane p-linnane merged commit 450acc5 into master Jul 17, 2024
5 checks passed
@p-linnane p-linnane deleted the various-add-rosetta-caveat-i branch July 17, 2024 02:25
@khipp khipp mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khipp khipp khipp left review comments

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
automerge-skip ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krehel @bevanjkay @khipp @p-linnane @BrewTestBot