openjdk@8 1.8.0-432 #194719

calvinit · 2024-10-17T06:20:21Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

calvinit · 2024-10-18T10:48:23Z

Why is the openjdk version used to test embulk here openjdk@21 instead of openjdk@8? Did the following check fail to work correctly?

on_arm do
  depends_on "openjdk@21"
end
on_intel do
  depends_on "openjdk@8"
end

I printed the content of the embulk script at bin/embulk on my Intel Mac, and it is as follows:

#!/bin/bash
export JAVA_HOME="${JAVA_HOME:-/usr/local/opt/openjdk@8/libexec/openjdk.jdk/Contents/Home}"
exec "${JAVA_HOME}/bin/java"  -jar "/usr/local/Cellar/embulk/0.11.5/libexec/embulk-0.11.5.jar" "$@"

It seems that the JAVA_HOME environment variable already has a value (which is /usr/local/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home), so the subsequent openjdk@8 environment variable value is not being applied. Alternatively, the value of java_version might actually be 21 (java_version = Hardware::CPU.intel? ? "1.8" : "21"). Could this be a bug in the test-bot or brew? Because when testing embulk individually, there is no problem, but here, when it is tested as a dependency of openjdk@8 1.8.0-432, the problem arises.

P.S. def install of embulk.rb:

def install
  java_version = Hardware::CPU.intel? ? "1.8" : "21"
  libexec.install "embulk-#{version}.jar"
  bin.write_jar_script libexec/"embulk-#{version}.jar", "embulk", java_version:
end

calvinit · 2024-10-21T06:41:36Z

Help wanted! @cho-m
Why is the embulk test section unable to correctly retrieve the value of the JAVA_HOME environment variable?
#191470

calvinit · 2024-11-01T07:31:39Z

Why is the openjdk version used to test embulk here openjdk@21 instead of openjdk@8? Did the following check fail to work correctly?
on_arm do
  depends_on "openjdk@21"
end
on_intel do
  depends_on "openjdk@8"
end
I printed the content of the embulk script at bin/embulk on my Intel Mac, and it is as follows:
#!/bin/bash
export JAVA_HOME="${JAVA_HOME:-/usr/local/opt/openjdk@8/libexec/openjdk.jdk/Contents/Home}"
exec "${JAVA_HOME}/bin/java"  -jar "/usr/local/Cellar/embulk/0.11.5/libexec/embulk-0.11.5.jar" "$@"
It seems that the JAVA_HOME environment variable already has a value (which is /usr/local/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home), so the subsequent openjdk@8 environment variable value is not being applied. Alternatively, the value of java_version might actually be 21 (java_version = Hardware::CPU.intel? ? "1.8" : "21"). Could this be a bug in the test-bot or brew? Because when testing embulk individually, there is no problem, but here, when it is tested as a dependency of openjdk@8 1.8.0-432, the problem arises.

P.S. def install of embulk.rb:
def install
  java_version = Hardware::CPU.intel? ? "1.8" : "21"
  libexec.install "embulk-#{version}.jar"
  bin.write_jar_script libexec/"embulk-#{version}.jar", "embulk", java_version:
end

I opened an issue: Homebrew/brew#18695

Bo98 · 2024-11-01T08:02:34Z

To clarify the changes in this PR, since JNF (JavaNativeFoundation.framework) is incomplete in macOS Sonoma or newer (but openjdk@8 depends on it), we have pre-built it ourselves and are using it.

Did you try the header thing I suggested? I ask because in theory it should still be possible to link against system JNF as the linker information does still ship with the SDK - only the headers were removed:

resource("JavaNativeFoundation").stage(buildpath/"JNF")
args << "--with-extra-cflags=-isystem #{buildpath/"JNF/apple/JavaNativeFoundation"}"

calvinit · 2024-11-01T08:08:31Z

To clarify the changes in this PR, since JNF (JavaNativeFoundation.framework) is incomplete in macOS Sonoma or newer (but openjdk@8 depends on it), we have pre-built it ourselves and are using it.

Did you try the header thing I suggested? I ask because in theory it should still be possible to link against system JNF as the linker information does still ship with the SDK - only the headers were removed:
resource("JavaNativeFoundation").stage(buildpath/"JNF")
args << "--with-extra-cflags=-isystem #{buildpath/"JNF/apple/JavaNativeFoundation"}"

Not yet, as I don’t know where to download these headers. However, there’s an error that might indicate it won’t necessarily work: '/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file)

Bo98 · 2024-11-01T08:14:58Z

That was using the resource you already have.

The test I ran locally was:

$ clang -arch x86_64 -isystem $(/usr/libexec/java_home)/include -isystem $(/usr/libexec/java_home)/include/darwin -isystem openjdk-iTunesOpenJDK-1014.0.2.12.1/apple/JavaNativeFoundation/ -framework JavaNativeFoundation test.m

(java_home stuff not needed in an OpenJDK build - just was because I was running it from outside)

#include <JavaNativeFoundation/JavaNativeFoundation.h>

int main()
{
    printf("%f\n", JNFJavaMillisToNSTimeInterval(978307210000)); // should equal 10.0
    return 0;
}

$ ./a.out
10.000000
$ otool -L a.out
a.out:
	/System/Library/Frameworks/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation (compatibility version 1.0.0, current version 84.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1345.100.2)

calvinit · 2024-11-01T11:15:59Z

That was using the resource you already have.

The test I ran locally was:

$ clang -arch x86_64 -isystem $(/usr/libexec/java_home)/include -isystem $(/usr/libexec/java_home)/include/darwin -isystem openjdk-iTunesOpenJDK-1014.0.2.12.1/apple/JavaNativeFoundation/ -framework JavaNativeFoundation test.m

(java_home stuff not needed in an OpenJDK build - just was because I was running it from outside)

#include <JavaNativeFoundation/JavaNativeFoundation.h>

int main()
{
    printf("%f\n", JNFJavaMillisToNSTimeInterval(978307210000)); // should equal 10.0
    return 0;
}

$ ./a.out
10.000000
$ otool -L a.out
a.out:
	/System/Library/Frameworks/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation (compatibility version 1.0.0, current version 84.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1345.100.2)

@Bo98 Hi, I have tried, but it still doesn't work, whether it's -I or -isystem.

==> bash configure --with-boot-jdk-jvmargs=-Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache --with-boot-jdk=/private/tmp/openjdkA8-20241101-6360-t2tyje/jdk8u-jdk8u432-ga/boot-jdk --with-debug-level=release --with-conf-name=release --with-jvm-variants=server --with-milestone=fcs --with-native-debug-symbols=none --with-update-version=432 --with-vendor-bug-url=https://github.com/Homebrew/homebrew-core/issues --with-vendor-name=Homebrew --with-vendor-url=https://github.com/Homebrew/homebrew-core/issues --with-vendor-vm-bug-url=https://github.com/Homebrew/homebrew-core/issues --with-giflib=system --with-toolchain-type=clang --with-zlib=system --with-extra-cflags=-isystem/private/tmp/JavaNativeFoundation-20241101-6360-wbss6w/openjdk-iTunesOpenJDK-1014.0.2.12.1/apple/JavaNativeFoundation/JavaNativeFoundation --with-extra-cxxflags=-isystem/private/tmp/JavaNativeFoundation-20241101-6360-wbss6w/openjdk-iTunesOpenJDK-1014.0.2.12.1/apple/JavaNativeFoundation/JavaNativeFoundation --with-extra-ldflags=-Wl,-rpath,@loader_path/server -Wl,-rpath,/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks

See: https://github.com/Homebrew/homebrew-core/actions/runs/11634188568/job/32401061493?pr=194719#step:3:1131

Compiling /private/tmp/openjdkA8-20241101-6360-t2tyje/jdk8u-jdk8u432-ga/hotspot/src/share/vm/runtime/vm_version.cpp
  /private/tmp/openjdkA8-20241101-6360-t2tyje/jdk8u-jdk8u432-ga/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m:27:9: fatal error: 'JavaNativeFoundation/JavaNativeFoundation.h' file not found
     27 | #import <JavaNativeFoundation/JavaNativeFoundation.h>
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /private/tmp/openjdkA8-20241101-6360-t2tyje/jdk8u-jdk8u432-ga/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m:27:9: note: did not find header 'JavaNativeFoundation.h' in framework 'JavaNativeFoundation' (loaded from '/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks')
  1 error generated.
  make[6]: *** [libsaproc.dylib] Error 1
  make[6]: *** Waiting for unfinished jobs....

From the error log above, it seems that it will look for headers in framework 'JavaNativeFoundation' rather than those provided by -I or -isystem (note: did not find header 'JavaNativeFoundation.h' in framework 'JavaNativeFoundation').

What did I mainly change? ↓↓↓

if OS.mac?
  # Work around Xcode 16 bug: https://bugs.openjdk.org/browse/JDK-8340341
  ENV.append_to_cflags("-mllvm -enable-constraint-elimination=0") if DevelopmentTools.clang_build_version == 1600

  args += %w[
    --with-toolchain-type=clang
    --with-zlib=system
  ]

  # NOTE: Since macOS Sonoma or newer do not include the required headersfor JNF (JavaNativeFoundation.framework),
  # so we will use the headers provided at https://github.com/apple/openjdk.
  if MacOS.version >= :sonoma
    resource "JavaNativeFoundation" do
      url "https://github.com/apple/openjdk/archive/refs/tags/iTunesOpenJDK-1014.0.2.12.1.tar.gz"
      sha256 "e8556a73ea36c75953078dfc1bafc9960e64593bc01e733bc772d2e6b519fd4a"

      stage do
        jnf_headers_search_path = Pathname.pwd/"apple/JavaNativeFoundation/JavaNativeFoundation"
        args += %W[
          --with-extra-cflags=-isystem#{jnf_headers_search_path}
          --with-extra-cxxflags=-isystem#{jnf_headers_search_path}
        ]
      end
    end

    ldflags << "-Wl,-rpath,#{MacOS.sdk_path}/System/Library/Frameworks"
  end
#......
end

Bo98 · 2024-11-01T22:12:47Z

Looks like there's one part that doesn't accept --with-extra-cflags properly, but something like this instead does work: Bo98@940717f

calvinit · 2024-11-03T00:31:26Z

Looks like there's one part that doesn't accept --with-extra-cflags properly, but something like this instead does work: Bo98@940717f

Yes, you’re right. I’ve referred to your commit and adjusted this PR, and it seems to be working fine now. Thank you very much!
Lastly, could we also consider including CI / macOS 15-x86_64 (pull_request) in this time?

calvinit · 2024-11-07T02:38:29Z

Should it be approved and merged into the master branch now? @Bo98 @carlocab @cho-m @chenrui333

Bo98 · 2024-11-08T06:09:56Z

Formula/o/openjdk@8.rb

+          ]
+        end
+        # Only the headers use our own; the others still use the built-in framework's.
+        ldflags << "-Wl,-rpath,#{MacOS.sdk_path}/System/Library/Frameworks"


This line is a bit weird. rpath provides the runtime path but the runtime framework doesn't exist here - only the linker information does.

What error do you get without this line?

==> bash common/autoconf/autogen.sh ==> bash configure --with-boot-jdk-jvmargs=-Duser.home=/Users/Homebrew/Library/Caches/Homebrew/java_cache --with-boot-jdk=/private/tmp/openjdkA8-20241108-21554-jhwpy6/jdk8u-jdk8u432-ga/ ==> make bootcycle-images CONF=release Last 15 lines from /Users/Homebrew/Library/Logs/Homebrew/openjdk@8/03.make: at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-21554-jhwpy6/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_security_icon_bw16_png.java] Error 1 make[3]: *** [/private/tmp/openjdkA8-20241108-21554-jhwpy6/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon64_java_icon48_png.java] Error 1 make[2]: *** [gensrc-only] Error 2 make[1]: *** [jdk-only] Error 2 make: *** [bootcycle-images-only] Error 2 READ THIS: https://docs.brew.sh/Troubleshooting

with --verbose:

## Starting jdk Importing CORBA bin.zip Importing CORBA classes.jar Importing CORBA src.zip Importing JAXP classes.jar Importing JAXP src.zip Importing JAXWS src.zip Importing JAXWS classes.jar Importing LANGTOOLS src.zip Importing LANGTOOLS classes.jar Generating charsetmapping classes Generating icon classes Generating exceptions classes Generating buffer classes Compiling 164 files for BUILD_TOOLS 注: 某些输入文件使用了未经检查或不安全的操作。注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。 Creating sun/util/LocaleDataMetaInfo.java from 423 found resources. Compiling 533 properties into resource bundles Copying and cleaning 53 properties Generating sun/misc/Version.java Generating sun/misc/Version.java compact1 Generating sun/misc/Version.java compact2 Generating sun/misc/Version.java compact3 Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 Classes: Table size 32 (5 bits), shift 1, max chain depth 3 Cache: Table size 32 (5 bits), shift 1, max chain depth 3 Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_java_icon16_png.java] Error 1 make[3]: *** Waiting for unfinished jobs.... Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633)make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon64_java_icon16_png.java] Error 1 at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_java_icon24_png.java] Error 1 Exception in thread "main" Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/servejava.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) Exception in thread "main" at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at java.lang.ClassLoader$NativeLibrary.load(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.security.AccessController.doPrivileged(Native Method) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at sun.awt.AppContext.getAppContext(AppContext.java:303)java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.awt.Toolkit$3.run(Toolkit.java:1636) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at java.awt.Toolkit$3.run(Toolkit.java:1634) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at java.security.AccessController.doPrivileged(Native Method) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at sun.awt.AppContext$2.run(AppContext.java:277) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at sun.awt.AppContext$2.run(AppContext.java:266) at java.lang.System.loadLibrary(System.java:1136) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit$3.run(Toolkit.java:1636) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at java.awt.Toolkit$3.run(Toolkit.java:1634) at sun.awt.AppContext.access$400(AppContext.java:135) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext$3.run(AppContext.java:321) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at sun.awt.AppContext$3.run(AppContext.java:304) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext.getAppContext(AppContext.java:303) at sun.awt.AppContext$2.run(AppContext.java:266) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at java.security.AccessController.doPrivileged(Native Method) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon64_java_icon32_png.java] Error 1 make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_java_icon32_png.java] Error 1 make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon64_java_icon24_png.java] Error 1 Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_java_icon48_png.java] Error 1 Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon64_java_icon48_png.java] Error 1 Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib: dlopen(/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib, 0x0001): Library not loaded: @rpath/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation Referenced from: <54157E5C-5613-3E68-9629-EAB0F966C6C5> /private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/libawt.dylib Reason: tried: '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/server/JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/./JavaNativeFoundation.framework/Versions/A/JavaNativeFoundation' (no such file), '/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/images/j2sdk-image/jre/lib/serve at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:843) at java.lang.System.loadLibrary(System.java:1136) at java.awt.Toolkit$3.run(Toolkit.java:1636) at java.awt.Toolkit$3.run(Toolkit.java:1634) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Toolkit.loadLibraries(Toolkit.java:1633) at java.awt.Toolkit.<clinit>(Toolkit.java:1670) at sun.awt.AppContext$2.run(AppContext.java:277) at sun.awt.AppContext$2.run(AppContext.java:266) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.initMainAppContext(AppContext.java:266) at sun.awt.AppContext.access$400(AppContext.java:135) at sun.awt.AppContext$3.run(AppContext.java:321) at sun.awt.AppContext$3.run(AppContext.java:304) at java.security.AccessController.doPrivileged(Native Method) at sun.awt.AppContext.getAppContext(AppContext.java:303) at javax.imageio.spi.IIORegistry.getDefaultInstance(IIORegistry.java:154) at javax.imageio.ImageIO.<clinit>(ImageIO.java:66) at build.tools.icondata.awt.ToBin.main(ToBin.java:35) make[3]: *** [/private/tmp/openjdkA8-20241108-95984-s14hji/jdk8u-jdk8u432-ga/build/release/bootcycle-build/jdk/gensrc/sun/awt//AWTIcon32_security_icon_bw16_png.java] Error 1 make[2]: *** [gensrc-only] Error 2 make[1]: *** [jdk-only] Error 2 make: *** [bootcycle-images-only] Error 2

Hello, I have resubmitted a new change without specifying @rpath this time. It seems like it should be fine. If there are no other issues, I think it’s ready to be merged into the master branch. Please let me know if there are any additional concerns. Thank you. @Bo98

github-actions bot added legacy Relates to a versioned @ formula no ARM bottle Formula has no ARM bottle labels Oct 17, 2024

calvinit mentioned this pull request Oct 17, 2024

embulk 0.11.5 #194723

Merged

6 tasks

chenrui333 force-pushed the openjdk@8_1.8.0-432 branch from ff25870 to 68bd427 Compare October 17, 2024 14:25

chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 17, 2024

chenrui333 added the test failure CI fails while running the test-do block label Oct 21, 2024

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 23, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch from fed29db to 68bd427 Compare October 23, 2024 07:30

github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 23, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch from 0b8bfc0 to 68bd427 Compare October 24, 2024 02:55

github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 24, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch 6 times, most recently from 79c16e8 to bd657e1 Compare October 25, 2024 11:46

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 25, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch from 16477cb to d3955dd Compare October 25, 2024 11:59

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 25, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch 3 times, most recently from 14edc3f to e34a3cd Compare October 25, 2024 12:41

chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 25, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch from e34a3cd to 6864d32 Compare October 29, 2024 08:00

calvinit force-pushed the openjdk@8_1.8.0-432 branch 3 times, most recently from 3dae490 to 77955fd Compare November 1, 2024 11:06

calvinit force-pushed the openjdk@8_1.8.0-432 branch 2 times, most recently from 133c53c to 34e252c Compare November 1, 2024 17:18

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch from 34e252c to 3a03359 Compare November 1, 2024 17:23

github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024

calvinit force-pushed the openjdk@8_1.8.0-432 branch 5 times, most recently from b069910 to 2448cc0 Compare November 1, 2024 19:36

calvinit force-pushed the openjdk@8_1.8.0-432 branch 2 times, most recently from aa34fd4 to 40066ab Compare November 2, 2024 18:25

calvinit requested review from Bo98 and carlocab November 4, 2024 02:11

cho-m removed the test failure CI fails while running the test-do block label Nov 4, 2024

Bo98 reviewed Nov 8, 2024

View reviewed changes

openjdk@8 1.8.0-432

0bf8394

calvinit force-pushed the openjdk@8_1.8.0-432 branch from 40066ab to 0bf8394 Compare November 11, 2024 12:20

calvinit requested a review from Bo98 November 12, 2024 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openjdk@8 1.8.0-432 #194719

openjdk@8 1.8.0-432 #194719

calvinit commented Oct 17, 2024 •

edited

Loading

calvinit commented Oct 18, 2024 •

edited

Loading

calvinit commented Oct 21, 2024

calvinit commented Nov 1, 2024

Bo98 commented Nov 1, 2024 •

edited

Loading

calvinit commented Nov 1, 2024

Bo98 commented Nov 1, 2024

calvinit commented Nov 1, 2024 •

edited

Loading

Bo98 commented Nov 1, 2024

calvinit commented Nov 3, 2024

calvinit commented Nov 7, 2024 •

edited

Loading

Bo98 Nov 8, 2024 •

edited

Loading

calvinit Nov 8, 2024

calvinit Nov 12, 2024

openjdk@8 1.8.0-432 #194719

Are you sure you want to change the base?

openjdk@8 1.8.0-432 #194719

Conversation

calvinit commented Oct 17, 2024 • edited Loading

calvinit commented Oct 18, 2024 • edited Loading

calvinit commented Oct 21, 2024

calvinit commented Nov 1, 2024

Bo98 commented Nov 1, 2024 • edited Loading

calvinit commented Nov 1, 2024

Bo98 commented Nov 1, 2024

calvinit commented Nov 1, 2024 • edited Loading

Bo98 commented Nov 1, 2024

calvinit commented Nov 3, 2024

calvinit commented Nov 7, 2024 • edited Loading

Bo98 Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

calvinit Nov 8, 2024

Choose a reason for hiding this comment

calvinit Nov 12, 2024

Choose a reason for hiding this comment

calvinit commented Oct 17, 2024 •

edited

Loading

calvinit commented Oct 18, 2024 •

edited

Loading

Bo98 commented Nov 1, 2024 •

edited

Loading

calvinit commented Nov 1, 2024 •

edited

Loading

calvinit commented Nov 7, 2024 •

edited

Loading

Bo98 Nov 8, 2024 •

edited

Loading