Skip to content

Makefile: file permissions, uninstall,.. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2014
Merged

Makefile: file permissions, uninstall,.. #35

merged 1 commit into from
Feb 20, 2014

Conversation

blaskovic
Copy link
Contributor

Hi,

I have done some modification to Makefile.

My changes:

  • I don't understand the double tab before commands
  • Man page should have its own prefix (it's not the same path on every distro)
  • You are copying files as root and do not check permissions? You have to do it! :)

@LuRsT
Copy link
Owner

LuRsT commented Feb 20, 2014

Hi @blaskovic,

Thank you so much for the pull request, this was my first time adding a Makefile to a project, and even with the help of @dotemacs, some things escaped me (aka not knowing much about Makefiles).

Thank you!

LuRsT added a commit that referenced this pull request Feb 20, 2014
@LuRsT
Merge pull request #35 from blaskovic/master
716abc8 
Makefile: file permissions, uninstall,..
@LuRsT LuRsT merged commit 716abc8 into LuRsT:master Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaskovic @LuRsT