-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Guide on Managing Auth Method for a PKP that Owns Itself #305
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for lit-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only note I have is that some blocks of code did not have any imports when they used methods in the Lit SDK. For example, the first two blocks and Transferring PKP Ownership to Itself. I'm sure the imports are elsewhere in the doc, but perhaps we want them anyways?
Great explanations on every part of the code. Reference links, splitting the code into blocks, and taking it piece-by-piece were appreciated for reading.
@awisniew207 Thanks Andrew, updated! The |
My only comment is where this guide lives. I think we should add it as a subset of the user wallets section, versus creating a whole new dropdown. What do you think? |
Agreed otherwise it's confusing what's the difference between User Wallets and PKPs if they have separate sections |
@DashKash54 This is what Eli and I settled on |
This is the corresponding guide for this code example
It covers:
process.env.ETHEREUM_PRIVATE_KEY_A
ETHEREUM_PRIVATE_KEY_A
ETHEREUM_PRIVATE_KEY_A
to the PKP's Ethereum addressETHEREUM_PRIVATE_KEY_A
to the PKP's Ethereum addressETHEREUM_PRIVATE_KEY_B
addPermittedAction
function on the PKP Permissions contract