Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Change threshold for checking marginals and making check optional #496

Merged
merged 11 commits into from
Aug 4, 2023
Merged

[Fix] Change threshold for checking marginals and making check optional #496

merged 11 commits into from
Aug 4, 2023

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Aug 4, 2023 •
edited
Loading

Types of changes

This PR aim at Fixing #429

  • Change in the threshold of the assert to require 6 decimals (more realistic for 32bits floats).
  • Add check_marginals parameter to emd,emd2,emd_1d that allows to skip teh test when False.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@rflamary rflamary merged commit 0b520f1 into master Aug 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rflamary