Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pre-commit with ruff,codespell,yamlint #660

Closed
wants to merge 9 commits into from
Closed

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Jul 18, 2024

Types of changes

This very large PR introduce a new style for the coe thta follow ruff formating with a fats pre-commit that will hopfully avoid "pep8" cmmts in the PRs in the future

Currently implements:

  • Ruff Lint (for main code and tetss/exmaples and doc)
  • Codespell (found many typos)
  • yamllint

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 46 lines in your changes missing coverage. Please review.

Project coverage is 96.67%. Comparing base (d0849a4) to head (284c500).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   96.67%   96.67%   -0.01%     
==========================================
  Files          85       85              
  Lines       16956    16948       -8     
==========================================
- Hits        16392    16384       -8     
  Misses        564      564              

@rflamary rflamary changed the title [WIP] pre-commit and style change to ruff [WIP] pre-commit with ruff,codespell,yamlint Jul 18, 2024
@rflamary rflamary closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant