RMD Preview: font-size setting #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it overwrite a themed document which has its own CSS font-size of those h1-h5 headers? |
|
It would depend on the html theme's css -- if it has higher priority styling then no. typically yes this will override that. |
|
Not sure if we should hard-code some font-size adjustment or just use some zoom parameter? |
|
I tried with some scenarios, looks like adjusting font size may result in many size inconsistencies between different HTML elements such as normal text, headers, images, code blocks, etc. I find using |
|
That sounds fair, it will work in more situations compared to just font size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Solves #1332 by injecting font-size in the preview HTML's css.
(If you do not have screenshot) How can I check this pull request?
Render the following, modifying the
r.rmarkdown.preview.fontSizesetting or themarkdown.preview.fontSizesetting to change the size of text in the preview.