This repository was archived by the owner on Jun 5, 2025. It is now read-only.
More SwiftUI #5
Merged
More SwiftUI #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces more SwiftUI support and updates key components for the Bookie app, focusing on concurrency improvements, UI refactoring, and new SwiftUI screens. The changes include updates to view models with MainActor annotations and a new MoyaProvider configuration, refactored stylesheet and coordinator classes using centralized AppColors with dedicated screen creation methods, and new SwiftUI implementations for both the Books and Book screens.
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Bookie/ViewModel/BooksViewModel.swift | Adds @mainactor annotations and updates the MoyaProvider instantiation. |
| Bookie/ViewModel/BookViewModel.swift | Updates the AnyBookScreen protocol to require an initializer with @mainactor. |
| Bookie/UI/MainStylesheet.swift | Refactors label registration into a helper function and uses centralized AppColors. |
| Bookie/UI/Coordinator.swift | Introduces SwiftUI coordinator methods and screen creation functions. |
| Bookie/UI/BooksScreenSwiftUI.swift | Adds a new SwiftUI Books screen using state bindings and updated view model interaction. |
| Bookie/UI/BooksScreen.swift | Improves collection view layout configuration by caching the layout cast to a variable. |
| Bookie/UI/BookScreenSwiftUI.swift | Implements the new SwiftUI Book screen with dependency-based navigation via bindings. |
| Bookie/UI/AppDelegate.swift | Updates the dependency container to register the SwiftUI-specific coordinator. |
| Bookie/Extensions.swift | Updates the signature of the mapAsync helper to align with new formatting practices. |
Files not reviewed (2)
- Bookie/cs.lproj/Localizable.strings: Language not supported
- Bookie/en.lproj/Localizable.strings: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.