This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Local storage #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions and adds local storage support via RealmSwift or SwiftData for the Bookie app while also updating test configurations and introducing new data source implementations.
- Upgrade Kingfisher to version 8.3.2
- Add RealmSwift dependency and configuration for local storage
- Refactor data fetching in BooksViewModel to use dependency injection with remote and local data sources
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| project.yml | Updated dependency versions and added RealmSwift configuration |
| BookieTests/BookieTests.swift | Added tests for new data source functionality and retroactive Equatable conformance |
| Bookie/ViewModel/SwiftDataSource.swift | Implemented local data source using SwiftData models for iOS 17 |
| Bookie/ViewModel/RealmDataSource.swift | Implemented alternative local data source for pre-iOS 17 devices |
| Bookie/ViewModel/GoogleRemoteDataSource.swift | Added remote data source using Moya to fetch book data |
| Bookie/ViewModel/BooksViewModel.swift | Modified reloadData to resolve remote/local data sources and update data |
| Bookie/UI/AppDelegate.swift | Configured dependency registrations for new data sources and Coordinator |
Comments suppressed due to low confidence (1)
Bookie/ViewModel/BooksViewModel.swift:86
- The local variable 'newSet' shadows the view model's property and is not assigned back, which may lead to an inconsistent state. Consider updating the view model's 'newSet' property (e.g. using 'self.newSet = …') to ensure that the latest data is stored.
let newSet = [DataSetKeyType: [Book]](grouping: newSetFiltered, by: { $0.volumeInfo.categories.map { .init($0) } ?? .init() }).mapValues { $0.sorted(by: \ .volumeInfo.title) }.map { DataSetItemType(model: $0.key, elements: $0.value) }.sorted { lhs, rhs in lhs.model.joined() < rhs.model.joined() }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.