This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Folders #7
Merged
Folders #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the dependency interfaces and coordinator implementations for the Bookie app. It consolidates protocol definitions and DI setup into a dedicated file, refactors the Coordinator to remove duplicate SwiftUI-specific implementations, and updates AppDelegate to leverage the new DI.swift configuration.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Bookie/ViewModel/GoogleRemoteDataSource.swift | Removed duplicate protocol definitions to simplify interface management. |
| Bookie/UI/DI.swift | Introduces a dedicated dependency injection container with protocol registrations. |
| Bookie/UI/CoordinatorSwiftUI.swift | Extracts the SwiftUI coordinator implementation from the base coordinator for clearer separation. |
| Bookie/UI/Coordinator.swift | Refactors the base coordinator by removing SwiftUI-specific methods and updating access levels. |
| Bookie/UI/AppDelegate.swift | Removes dependency injection setup in favor of the centralized DI.swift configuration. |
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors several view controllers and view models to streamline data reloading and dependency injection while updating DI configurations for SwiftData and RealmDataSource.
- Moved search text subscription logic from initializers into a dedicated ready() method.
- Updated DI registrations and default values in Coordinator.
- Added required initializers and refactored UI components to align with the new reactive workflow.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Bookie/ViewModel/BooksViewModel.swift | Moved search subscription to ready() and adjusted data saving location. |
| Bookie/UI/BooksScreenSwiftUI.swift | Updated binding implementations and replaced immediate reload data tasks. |
| Bookie/UI/BooksScreen.swift | Replaced Task-based reloadData with viewModel.ready() call. |
| Bookie/UI/BookScreenSwiftUI.swift | Added required initializer to remove duplicate definitions. |
| Bookie/UI/BookScreen.swift | Updated image setting to use local variable and added a guard clause. |
| Bookie/UI/AppDelegate.swift | Removed SwiftData and Swinject container definitions. |
| Bookie/DI/SwiftDataSource.swift | Updated BookSwiftData to conform to Identifiable with unique attribute. |
| Bookie/DI/RealmDataSource.swift | Refactored Realm model mapping and saving logic using then DSL. |
| Bookie/DI/GoogleRemoteDataSource.swift | Removed protocol definitions to simplify remote data source. |
| Bookie/DI/DI.swift | Introduced a new DI file with consolidated container registrations. |
| Bookie/DI/CoordinatorSwiftUI.swift | Added a new Coordinator for SwiftUI-based screens. |
| Bookie/DI/Coordinator.swift | Changed default search text value and removed deprecated subclass methods. |
Comments suppressed due to low confidence (1)
Bookie/DI/Coordinator.swift:13
- [nitpick] The default searchText value has been changed from "Karel" to "C", which may be unclear. Consider using a more descriptive or meaningful default value.
private var searchText = "C"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.