feat: dynamic golangci-lint versions and configuration #145
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7db43f1 to
f9e69dd
Compare
pmlanger
commented
Sep 8, 2025
pmlanger
commented
Sep 8, 2025
85f02bd to
89147de
Compare
|
🥷 Code experts: no user but you matched threshold 10 pmlanger has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
alexkravch
approved these changes
Sep 8, 2025
jhuliano
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://typeform.atlassian.net/browse/PLT-2300
Make the configuration file location of golangci-lint (
golangci.yaml) configurable.This is a preparation for the move to golangci-lint v2. The configuration files between v1 and v2 are not compatible, which means that once we move the golangci-lint executable to
2.x, a single location for the file is not sufficient, as some repos will be on v1, and others on v2.The defaults are the hardcoded values from today, with the exception of
ref, which is set to1.15.0(latest tag with av1configuration file).Tested for backwards compatibility: https://github.com/Typeform/event-dispatcher/actions/runs/17552732900/job/49848910468?pr=605