Support for withFieldGroup in solid js #1799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Related PR: #1783 Would be great if you could give each other feedback / cross checks. Remember that PR versions can be installed for local testing too. |
|
I'll be then closing this pr |
|
Expecting the pr #1783 to be merged asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Added support for withFieldGroup in solidjs. Now we can create the same withFieldGroup just like react in solid.
PS: the tests failed with result name undefined. But the types result passed.
I am new to solid but needed this feature very much. So I decided to make this pr. For any mistakes, forgive me.
✅ Checklist
pnpm test:pr.🚀 Release Impact