-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/update app to support new pollutants #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
courtneymyers
merged 48 commits into
master
from
feature/update-app-to-support-new-pollutants
Sep 28, 2021
Merged
Feature/update app to support new pollutants #26
courtneymyers
merged 48 commits into
master
from
feature/update-app-to-support-new-pollutants
Sep 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(actually renaming 'pollutants' to 'metrics' as 'generation' isn't a pollutant)
function to parse and pass nei JSON data if the metric is 'nei'
…llers, and update displacement API routes to include 'displacement' in URL
update getDisplacement() calculation to return data in a shape that's better suited for returning calculated data for multiple pollutants (for NEI pollutants), and update client app to work with new shape of returned data in displacement reducer
to account for passed 'nei' metric and properly calculate and return displacement data for pm2.5, vocs, and nh3
to correctly account for pollutants that aren't included in 'replacement' condition (e.g. 'vocs' and 'nh3' for now, but soon 'pm25' as its now calculated from NEI data, and not data in an RDF)
as its displacement value is calculated from NEI data now, and not pm2.5 data in the RDFs
and remove 'replacedOriginal' and 'replacedPostEere' values from setting pm25 original and post eere, as it's not longer eligible for replacement, since its value is calculated from NEI factors for each EGU
and update table styles (display units smaller, and wrap table in a container w/ its overflow css property set to scroll, to accommodate tables who's contents are too wide for their container...e.g. EmissionsTable
to only loop through hours and eeres once when the provided 'metric' parameter is 'nei' (cuts calculation time in a third for that 'metric')
…ates in DisplacementsTable component
(and not always rounding up as we were previously doing)
and display it in the DisplacementsTable component
and add tooltips explaining what ozone season is
(better named variables, more informative comments)
to support debugging hourly data for each EGU (NOTE: not used in production – only used for local development to test calculated hourly values for each EGU)
to debug a specific EGU instead of debugging all EGUs
(generated from latest Excel file)
to not trigger the browser's popup blocking, by opening a new tab immediately, and redirecting it to the correct COBRA app URL once the COBRA API is ready
and logic for formatting data for submission to COBRA API
if cobra token api is online
to check returned COBRA API version number when determining if the COBRA API is ready for AVERT integration
(so if the COBRAConnection isn't ready to be displayed, due to the COBRA API not being ready, the heading also isn't shown...the DataDownload component is always shown, but moved the header into it to be consistent)
response to determine if the COBRA integration should be displayed (and not require the version API endpoint at all). Also simplify fetch error handling to return inner fecth and only catch/handle all errors at the top level fetch, as we're handling them all the same with the same error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the way PM2.5 displacement data is calculated, and adds in VOCs and NH3 to web app's output. Displacement data for all three of those pollutants (PM2.5, VOCs, and NH3) are calculated from each RDF's heat data, and annual point-source data from the National Emissions Inventory.