Skip to content

Remove copyStyleSheets #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Remove copyStyleSheets #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ async function enterPiP() {
const pipOptions = {
width: player.clientWidth,
height: player.clientHeight,
copyStyleSheets: true,
};

pipWindow = await documentPictureInPicture.requestWindow(pipOptions);
Expand Down
28 changes: 3 additions & 25 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ interface DocumentPictureInPicture : EventTarget {
dictionary DocumentPictureInPictureOptions {
[EnforceRange] unsigned long long width = 0;
[EnforceRange] unsigned long long height = 0;
boolean copyStyleSheets = false;
};

[Exposed=Window]
Expand Down Expand Up @@ -214,18 +213,14 @@ problems.
pixels.
14. Configure |pip traversable|'s <a>active browsing context</a>'s window to
float on top of other windows.
15. If |options|["{{DocumentPictureInPictureOptions/copyStyleSheets}}"] exists and
is <code>true</code>, then run the <a>copy CSS Style Sheets to Document Picture-in-Picture algorithm</a>
given <a>this</a>'s <a>relevant global object</a>'s <a>navigable</a>'s
<a>active document</a> and |pip traversable|'s <a>active document</a>.
16. Set <a>this</a>'s <a>last-opened window</a> to |pip traversable|'s <a>active window</a>.
17. <a>Queue a global task</a> on the
15. Set <a>this</a>'s <a>last-opened window</a> to |pip traversable|'s <a>active window</a>.
16. <a>Queue a global task</a> on the
<a data-link-type="idl" href="https://html.spec.whatwg.org/multipage/webappapis.html#dom-manipulation-task-source">DOM manipulation task source</a>
given <a>this</a>'s <a>relevant global object</a> to <a>fire an event</a>
named {{enter}} using {{DocumentPictureInPictureEvent}} on
<a>this</a> with its {{DocumentPictureInPictureEvent/window}} attribute
initialized to |pip traversable|'s <a>active window</a>.
18. Return |pip traversable|'s <a>active window</a>.
17. Return |pip traversable|'s <a>active window</a>.

</div>

Expand Down Expand Up @@ -295,22 +290,6 @@ To <dfn>close any existing picture-in-picture windows</dfn>:
<a data-link-type="dfn" href="https://w3c.github.io/picture-in-picture/#exit-picture-in-picture-algorithm">exit Picture-in-Picture algorithm</a>
with |navigable|'s <a>active document</a>.

## Copy Style Sheets to Document Picture-in-Picture ## {#copy-style-sheets-to-document-picture-in-picture}

The <dfn>copy CSS Style Sheets to Document Picture-in-Picture algorithm</dfn>
steps, given |source document| and |pip document| are:
1. For each |sheet| of |source document|'s <a>document or shadow root CSS style sheets</a>:
1. If |sheet|'s <a data-link-type="idl" href="https://drafts.csswg.org/cssom/#dom-stylesheet-disabled">disabled</a>
attribute is set, then continue.
2. Create a new CSSStyleSheet |copied sheet|, which is a copy of |sheet|.
3. Run the <a>add a CSS style sheet</a> steps with |copied sheet| and |pip document|.

<p class="note">
Copying CSS Style Sheets to Document Picture-in-Picture is a one-time copy, and
any further changes to |source document|'s <a>document or shadow root CSS style sheets</a>
will not be copied.
</p>

## One PiP Window ## {#one-pip-window}

Any <a>top-level traversable</a> must have at most one document
Expand Down Expand Up @@ -429,7 +408,6 @@ function enterPiP() {
const pipOptions = {
width: player.clientWidth,
height: player.clientHeight,
copyStyleSheets: true
};

documentPictureInPicture.requestWindow(pipOptions).then((pipWin) => {
Expand Down