Fix selects of packed fields in GlobalStructOptimization #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Sep 17, 2024
| // that constant. | ||
| ret = value.getConstant().makeExpression(wasm); | ||
| // that constant, and handle if the field is packed. | ||
| auto* expr = value.getConstant().makeExpression(wasm); |
There was a problem hiding this comment.
It might be worth considering a refactoring that would put the knowledge that we are representing an i8 or i16 value directly into the Literal, which would prevent users from having to remember and specially handle the case of packed values.
There was a problem hiding this comment.
Interesting idea. I think perhaps not on PossibleConstantValues which just means a wasm value, not necessarily one stored to a heap field. Adding this info there would add size + overhead in places we don't need it (some passes store very many such values, e.g. GUFA). But perhaps we could have HeapStoredValue or such. I'll keep thinking about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We emit a select between two objects when only two objects exist of a particular
type. However, if the field is packed, we did not handle truncating the written
values.