[wasm-split] Configure split functions rather than kept functions #6949
Conversation
Maintain the invariant that every defined functions belongs to either the set of kept functions or the set of split functions. Functions are kept by default except when --keep-funcs is specified without --split-funcs on the command line. This is mostly NFC except that it changes the default behavior when no arguments are specified on the command line to keep all functions. This will simplify a follow-on PR that switches from passing the kept functions to the module splitting utility to passing the split functions.
The configuration for the module splitting utility previous took a set of functions to keep in the primary module. Change it to take a list of functions to split into the secondary module instead. This improves the code quality in multi-split mode because it keeps stub functions generated by previous splits from being moved into secondary modules during later splits.
| @@ -7,8 +7,10 @@ | |||
| ;; RUN: wasm-dis %t3.wasm | filecheck %s --check-prefix=CHECK-C | |||
|
|
|||
| (module | |||
| (type $ret-i32 (func (result i32))) | |||
| ;; PRIMARY: (type $ret-i64 (func (result i64))) | |||
There was a problem hiding this comment.
Why is this not lined up with the declaration below?
There was a problem hiding this comment.
Because $ret-i32 is in the way. output $ret-i64 < output $ret-i32 < input $ret-i32 < input $ret-i64.
There was a problem hiding this comment.
But don't we now match the input order? Or does wasm-split reorder?
There was a problem hiding this comment.
No, we decided to make all the tools reorder by default and preserve the input order only when --preserve-input-order is passed.
There was a problem hiding this comment.
Oh, sorry, I remembered that wrong then. Yeah, the issue was the reordered output was more optimal, and we didn't want to risk production builds.
There was a problem hiding this comment.
Anyhow, using the flag might help here, but if it's just one line sgtm either way.
There was a problem hiding this comment.
I'll skip it for now because we would have to add --preserve-type-order to each of the 5 commands at the top, which I think would be more annoying than this one line.
The configuration for the module splitting utility previous took a set
of functions to keep in the primary module. Change it to take a list of
functions to split into the secondary module instead. This improves the
code quality in multi-split mode because it keeps stub functions
generated by previous splits from being moved into secondary modules
during later splits.