Block Comments: Try alternative method for spotlight #72194
Merged
+10
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -100 B (0%) Total Size: 2.03 MB
ℹ️ View Unchanged
|
|
Results from the first Performance tests run. The block selection ( |
t-hamano
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Nice approach! I've also seen improvements locally. I ran the performance test five times.
npm run test:performance -- test/performance/specs/post-editor.spec.js --grep "Selecting blocks"
Before:
┌─────────┬──────────────────────────┐
│ (index) │ value │
├─────────┼──────────────────────────┤
│ focus │ '44.25 ms +7.48% -2.46%' │
│ focus │ '43.85 ms +6.36% -5.09%' │
│ focus │ '44.01 ms +3.09% -3.16%' │
│ focus │ '50.03 ms +3.46% -10.57%' │
│ focus │ '44.27 ms +2.91% -1.38%' │
After
┌─────────┬──────────────────────────┐
│ (index) │ value │
├─────────┼──────────────────────────┤
│ focus │ '36.79 ms +2.72% -2.56%' │
│ focus │ '35.95 ms +5.51% -1.97%' │
│ focus │ '38.12 ms +2.02% -10.26%' │
│ focus │ '36.79 ms +1.47% -3.59%' │
│ focus │ '36.22 ms +10.13% -4.45%' │
|
Thanks for the confirmation, @t-hamano! The second run of performance tests has similar results. I'm not sure why the remaining e2e test is failing. I restarted it once more. |
|
Flaky tests detected in 7ae8f05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18365616372
|
|
Thanks for the follow-up folks. The job failed in trunk (I just restarted it) but the PR did improve the perf metric. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #72126.
An experiment that tries to reuse existing logic for focus mode.
Why?
Mostly testing if it has any effect on performance.
Testing Instructions
The experience from #72126 should work as before.
Testing Instructions for Keyboard
Same.