Skip to content

[charts] Allow gestures to be cancelled from events #19834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[charts] Allow gestures to be cancelled from events #19834

wants to merge 4 commits into from
+279 −92

Conversation

JCQuintas
Copy link
Member

  • Adds a event.details.cancel()

@JCQuintas JCQuintas requested a review from a team October 6, 2025 15:37
@JCQuintas JCQuintas self-assigned this Oct 6, 2025
@JCQuintas JCQuintas added type: new feature Expand the scope of the product to solve a new problem. scope: charts Changes related to the charts. labels Oct 6, 2025
@mui-bot
Copy link

mui-bot commented Oct 6, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19834--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 🔺+409B(+0.12%) 🔺+43B(+0.04%)
@mui/x-charts-pro 🔺+409B(+0.09%) 🔺+46B(+0.03%)
@mui/x-charts-premium 🔺+409B(+0.09%) 🔺+43B(+0.03%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 48f11a3

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19834 will not alter performance

Comparing JCQuintas:make-gestures-cancellable (b65cfce) with master (f8623a5)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (0aaf6aa) during the generation of this report, so f8623a5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@JCQuintas JCQuintas marked this pull request as draft October 6, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JCQuintas JCQuintas

Labels
scope: charts Changes related to the charts. type: new feature Expand the scope of the product to solve a new problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCQuintas @mui-bot