Skip to content

Format string #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 8, 2025
Merged

Format string #368

merged 8 commits into from
Jan 8, 2025

Conversation

ManushPatell
Copy link
Contributor

@ManushPatell ManushPatell commented Dec 30, 2024 •
edited
Loading

  • Implemented std::format in C++ to the appropriate files. I wasn't able to check all the files through testing but the demo for BasicIO and Blink worked as intended
  • Created the branch off of a previous branch so the previous branches commits are there <-- did rebase thanks to Blake

BlakeFreer
BlakeFreer requested changes Dec 31, 2024
View reviewed changes
BlakeFreer
BlakeFreer requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@BlakeFreer BlakeFreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small note, otherwise good.

BlakeFreer
BlakeFreer requested changes Jan 6, 2025
View reviewed changes
@BlakeFreer BlakeFreer linked an issue Jan 7, 2025 that may be closed by this pull request
C++20 std::format #238
Closed
@BlakeFreer
Copy link
Contributor

Still need to update:

  • mcal/cli/periph: adc.h, analog_output.h

BlakeFreer
BlakeFreer requested changes Jan 7, 2025
View reviewed changes
@BlakeFreer BlakeFreer merged commit edba01d into main Jan 8, 2025
1 check passed
@BlakeFreer BlakeFreer deleted the format_string branch January 8, 2025 18:29
@BlakeFreer BlakeFreer mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlakeFreer BlakeFreer BlakeFreer approved these changes

@samparent97 samparent97 Awaiting requested review from samparent97 samparent97 is a code owner

@TylerStAmour TylerStAmour Awaiting requested review from TylerStAmour TylerStAmour is a code owner

@langei langei Awaiting requested review from langei langei is a code owner

@CameronBeneteau CameronBeneteau Awaiting requested review from CameronBeneteau CameronBeneteau is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++20 std::format
2 participants
@ManushPatell @BlakeFreer