fix(ra-ui-materialui): Fix <TabbedFormView/> to support string ids with spaces #10324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for the PR! Would you mind adding a story and a test? Besides, don't we have the same issue with |
|
Hello! No, we don't have the same issue with the |
|
@djhi i just added a story & unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: TabbedForm Support for IDs with Spaces
Problem:
TabbedFormfails to render tabs when the entity ID contains spaces.This occurs because
TabbedFormViewcompares the raw location.pathname (which containsencoded spaces as %20) with tab paths, causing the path matching to fail.
Solution:
Fixed
getDecodedPathnameutility function that:This ensures consistent path matching regardless of spaces in entity IDs, allowing
TabbedForm to properly render and navigate between tabs.
Fixes #9545