[QA] set_control action http request tests
#1436
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-10-02 13:01:53 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/ |
| # filter interaction between charts (3 http) | ||
| element = page.locator('path[class="point plotly-customdata"]').nth(20) | ||
| box = element.bounding_box() | ||
| page.mouse.click(box["x"] + box["width"] / 2, box["y"] + box["height"] / 2) | ||
| check_http_requests_count(page, http_requests_paths, 5) |
There was a problem hiding this comment.
When you remove unnecessary custom action from here https://github.com/mckinsey/vizro/pull/1422/files#r2410395577, the number of https will drop 5 -> 4. After that, could you explain here in the comment what happens under the hood so that clicking on the graph triggers two instead of one http request (which is intuitively expected number as one action triggers one http). You can explain that implicit actions chain happens and that set_control implicitly triggers the filter_action.
| # filter interaction between af grid and chart (2 http) | ||
| page.get_by_role("gridcell", name="Europe").nth(0).click() | ||
| check_http_requests_count(page, http_requests_paths, 4) |
| # filter drill_through between charts (3 http) | ||
| element = page.locator('path[class="point plotly-customdata"]').nth(20) | ||
| box = element.bounding_box() | ||
| page.mouse.click(box["x"] + box["width"] / 2, box["y"] + box["height"] / 2) | ||
| check_http_requests_count(page, http_requests_paths, 5) |
There was a problem hiding this comment.
Let's also add a comment here and in other tests below that explain why 3 http requests happen. (set_control + 2 for on page load that happen while opening a targeted page)
|
|
||
| # checking that no additional http has occurred | ||
| check_http_requests_count(page, http_requests_paths, 4, sleep=cnst.HTTP_TIMEOUT_LONG) | ||
|
|
There was a problem hiding this comment.
When you add a test(s) for chaining multiple set_control actions (see this comment), could you also include an additional test(s) here to cover that scenario(s)? Actually, that will be the most important http test for the set_control feature.
Description
http requests count for
set_controlaction drill_through and interactionsNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":