Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken link in “CSP: require-trusted-types-for” doc #21347

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix a broken link in “CSP: require-trusted-types-for” doc #21347

merged 1 commit into from
Oct 7, 2022

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #21337

@sideshowbarker sideshowbarker requested a review from a team as a code owner October 7, 2022 02:36
@github-actions github-actions bot added the Content:HTTP HTTP docs label Oct 7, 2022
@sideshowbarker sideshowbarker mentioned this pull request Oct 7, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/require-trusted-types-for
Title: CSP: require-trusted-types-for

@sideshowbarker
Copy link
Collaborator Author

@wbamberg Per your comment at #21337 (comment), we could alternatively just drop this from the See Also section. I’m happy with doing it either way

wbamberg
wbamberg approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking some more, it seems useful to highlight the link to injection sinks, so let's keep it. Thank you @sideshowbarker !

@wbamberg wbamberg merged commit 7aa6f35 into main Oct 7, 2022
@wbamberg wbamberg deleted the sideshowbarker/require-trusted-types-for-404-fix branch October 7, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena

Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link - 'DOM XSS injection sinks covered by Trusted Types'
2 participants
@sideshowbarker @wbamberg