Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial-letter: clarify usage and see also #36581

Merged
merged 8 commits into from
Nov 6, 2024
Merged

initial-letter: clarify usage and see also #36581

merged 8 commits into from
Nov 6, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 30, 2024

make it clear in the intro which elements apply.
add selectors for those elements to the see also

@estelle estelle requested a review from a team as a code owner October 30, 2024 19:21
@estelle estelle requested review from chrisdavidmills and removed request for a team October 30, 2024 19:21
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/initial-letter
Title: initial-letter

(comment last updated: 2024-10-30 22:17:16)

estelle and others added 2 commits October 30, 2024 14:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Oct 30, 2024
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle all looks good to me! My only suggestion would be that maybe you could add some vertical margin between each line of your new example, so it is a little easier to see what is going on. They are currently cramped close together.

@estelle
Copy link
Member Author

estelle commented Nov 6, 2024

@estelle all looks good to me! My only suggestion would be that maybe you could add some vertical margin between each line of your new example, so it is a little easier to see what is going on. They are currently cramped close together.

i intentionally didn't, to show the issue, but maybe i should add an example with multiple lines of texts to make that clearer. will do it in a different PR.

@estelle estelle merged commit 33cd63a into main Nov 6, 2024
9 checks passed
@estelle estelle deleted the estelle-patch-2 branch November 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants