Add information about FireFox override setting for disablePictureInPicture #36678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Overrides | ||
|
|
||
| FireFox users can decide to ignore the request to disable PiP by changing the `media.videocontrols.picture-in-picture.respect-disablePictureInPicture` setting. |
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| FireFox users can decide to ignore the request to disable PiP by changing the `media.videocontrols.picture-in-picture.respect-disablePictureInPicture` setting. | |
| FireFox users can decide to ignore the request to disable PiP by changing the `media.videocontrols.picture-in-picture.respect-disablePictureInPicture` setting. |
Josh-Cena
reviewed
Nov 6, 2024
Comment on lines
25
to
27
| ## Overrides | ||
|
|
||
| FireFox users can decide to ignore the request to disable PiP by changing the `media.videocontrols.picture-in-picture.respect-disablePictureInPicture` setting. |
There was a problem hiding this comment.
This breaks our page structure conventions. Please make this a single paragraph under the introduction (before "Value"), because we don't have an H2 called "Overrides". Also, it's "Firefox". Also, I suggest a minor rephrase to let it less browser-specific:
This value only represents a request from the website to the user agent. User configuration may change the eventual behavior—for example, Firefox users can change the
media.videocontrols.picture-in-picture.respect-disablePictureInPicturesetting to ignore the request to disable PiP.
Josh-Cena
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added information about a FireFox-specific setting users can set to override this setting.
Motivation
Might be useful for other people to know; both consumers & devs to keep into mind that this is an option.
Additional details
Related issues and pull requests