Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: remove duplicate load_peft_model #124

Merged
merged 1 commit into from
Aug 22, 2023
Merged

bugfix: remove duplicate load_peft_model #124

merged 1 commit into from
Aug 22, 2023

Conversation

polym
Copy link
Contributor

@polym polym commented Aug 17, 2023

What does this PR do?

Fixes #123

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@facebook-github-bot
Copy link

Hi @polym!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@HamidShojanazeri HamidShojanazeri mentioned this pull request Aug 20, 2023
Closed
7 tasks
@chauhang
Copy link
Contributor

@polym Thanks for submitting this PR. Please sign the CLA to move forward with the PR merging

@polym
Copy link
Contributor Author

polym commented Aug 21, 2023

@facebook-github-bot re-run

@HamidShojanazeri HamidShojanazeri merged commit 971c079 into meta-llama:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamidShojanazeri HamidShojanazeri Awaiting requested review from HamidShojanazeri

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inference.py call load_peft_model twice
4 participants
@polym @facebook-github-bot @chauhang @HamidShojanazeri