Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Cover offset() with e2e tests and find bugs #47806

Closed
uladzimirdev opened this issue Sep 10, 2024 · 0 comments · Fixed by #47628
Closed

[Epic] Cover offset() with e2e tests and find bugs #47806

uladzimirdev opened this issue Sep 10, 2024 · 0 comments · Fixed by #47628
Assignees
Labels
.Epic Feature Implementation or Project .Team/Querying

Comments

@uladzimirdev
Copy link
Contributor

uladzimirdev commented Sep 10, 2024

Links

Implementation Plan

  • create testing plan
  • add tests
  • file bugs

Testing plan


  • implicit joins
    • when custom column is in the first place of breakout
      • works with custom column that contains a function
      • works with custom column that contains a column
      • works when custom column is a simple expression
    • when custom column is not in the first place of breakout
      • works with custom column that contains a function
      • works with custom column that contains a column
      • works when custom column is a simple expression
  • explicit joins
    • offset expression not in the first place in aggregation
    • offset expression is in the first place in aggregation
    • offset and avg function applied to custom column
  • when expression contains a standard function with offset
    • works with avg
    • works with 3 breakouts
  • works with filtering using segment
  • works with metric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Epic Feature Implementation or Project .Team/Querying
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant