Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use Saved Question, when original question uses "Display values"="Use foreign key" #10474

Closed
flamber opened this issue Aug 2, 2019 · 8 comments
Closed

Cannot use Saved Question, when original question uses "Display values"="Use foreign key" #10474

flamber opened this issue Aug 2, 2019 · 8 comments
Assignees
@camsaul
Labels
Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions Querying/Remapping Remapped display values, whether human-readable values or Field->Field remappings .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.36.5

Comments

@flamber
Copy link
Contributor

flamber commented Aug 2, 2019 •
edited
Loading

Describe the bug
When a field in Admin > Data Model has "Display values"="Use foreign key", then the question cannot be used as Saved Question.
It will just return an error that the foreign table column was not found (depending on database, the error might be different):
Invalid column name "TITLE"
Column "source.TITLE" not found

To Reproduce
Steps to reproduce with Sample Dataset:

  1. Go to Admin > Data Model > Sample Dataset > Orders > Product ID ⚙️
  2. Change "Display values"="Use foreign key", connected to "Title"
  3. Create a QB/Simple question of Orders and save it as "Q1"
  4. Create a new question and use the "Q1" in Saved Questions, and run it.
  5. Fails with the error: Column "source.TITLE" not found

Information about your Metabase Installation:
Metabase 0.32.10 (prod) and 0.33.0-RC1 (test)
This used to work in 0.32.9
@flamber flamber added the Type:Bug Product defects label Aug 2, 2019
@flamber flamber mentioned this issue Sep 25, 2019
Closed
@salsakran salsakran added Querying/Nested Queries Questions based on other saved questions Priority:P2 Average run of the mill bug Query Builder labels Oct 6, 2019
This was referenced Feb 13, 2020
Closed
Closed
This was referenced May 8, 2020
Closed
Closed
Closed
@flamber flamber mentioned this issue May 30, 2020
Open
@sbelak sbelak mentioned this issue Sep 2, 2020
Merged
@camsaul camsaul added this to the 0.36.5 milestone Sep 11, 2020
@camsaul
Copy link
Member

camsaul commented Sep 11, 2020

Fixed by #13202

@camsaul camsaul closed this as completed Sep 11, 2020
@flamber flamber mentioned this issue Feb 3, 2021
Closed
@nemanjaglumac
Copy link
Member

Should we reopen and move the milestone to 38?

nemanjaglumac added a commit that referenced this issue Feb 3, 2021
@nemanjaglumac
Add repro for #10474 [ci skip]
6d3a64e
@nemanjaglumac nemanjaglumac mentioned this issue Feb 3, 2021
Merged
@flamber
Copy link
Contributor Author

flamber commented Feb 3, 2021 •
edited
Loading

No, it's not an issue in any official releases.

@nemanjaglumac
Copy link
Member

But it is a regression?

@flamber
Copy link
Contributor Author

flamber commented Feb 3, 2021

But it's not in any releases. Issues only get a milestone, when it's fixed in that - this was fixed and a PR before 0.38 has caused a regression, which will be fixed before 0.38.0 - otherwise it will be reopened and regression added. It's mainly tracked in #14629

nemanjaglumac added a commit that referenced this issue Feb 3, 2021
@nemanjaglumac
#10474 Repro: Cannot use Saved Question with remapped "Display values…
d19d8de 
…"="Use foreign key" [ci skip] (#14638)

- Reproduces #10474 (`.Regression`!)
- VERY related issue #14629
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Feb 3, 2021
@flamber flamber mentioned this issue Feb 5, 2021
Merged
@camsaul
Copy link
Member

camsaul commented Feb 5, 2021 •
edited
Loading

If it's a regression in master or whatever we should definitely reopen it, or open a new issue to track it. Otherwise the eng team won't find out about it until we ship 0.38.0. I didn't know about it until today.

It doesn't sound like the same issue as #14629, because otherwise I wouldn't have been able to fix #14629 without fixing this

@camsaul camsaul reopened this Feb 5, 2021
@camsaul camsaul self-assigned this Feb 5, 2021
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camsaul camsaul

Labels
Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions Querying/Remapping Remapped display values, whether human-readable values or Field->Field remappings .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.36.5
Development

No branches or pull requests
5 participants
@salsakran @flamber @camsaul @mazameli @nemanjaglumac