Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native/SQL variable panel, cards jumps around when editing #11580

Closed
flamber opened this issue Dec 20, 2019 · 2 comments · Fixed by #11582
Closed

Native/SQL variable panel, cards jumps around when editing #11580

flamber opened this issue Dec 20, 2019 · 2 comments · Fixed by #11582
Assignees
@paulrosenzweig
Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.34.1

Comments

@flamber
Copy link
Contributor

flamber commented Dec 20, 2019

Describe the bug
When editing the variable sidebar filters, the cards jumps around (Chris Kross - Jump 🎵).

Logs No errors/warnings related to this.

To Reproduce

  1. Native query > click Variables-icon (right side) > click "Try it" on first example
  2. Add AND {{another}} after ... {{category}} (another is now add as the last card)
  3. Give another a "Filter label" and try to click "Variable type" (another is now the first card)
  4. Set the "Variable type" for another to "Field Filter" (another is now the last card)

Expected behavior
Keep the same position throughout - manual reordering is covered in #9357.

Screenshots
Screencast 2019-12-20 14 58 15

Information about your Metabase Installation:
Metabase 0.34.0 various browsers and backends.

Severity
I would normally give this P2, but it's making it almost impossible work with filters, so P1.

Additional context
https://discourse.metabase.com/t/v0-34-0-unstable-variables-panel/8413
@flamber flamber added .Needs Triage Type:Bug Product defects labels Dec 20, 2019
@salsakran salsakran added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. and removed .Needs Triage labels Dec 20, 2019
@salsakran
Copy link
Contributor

P1 since this is a highly trafficked path and it's a regression. Could be a P1.5 but rounded "up".

@paulrosenzweig paulrosenzweig self-assigned this Dec 20, 2019
@paulrosenzweig paulrosenzweig mentioned this issue Dec 20, 2019
Merged
@MarcGJA
Copy link

MarcGJA commented Dec 20, 2019

And it's populating corresponding fields in the next variable's sub-panel too. And the default filter widget field is almost impossible to fill, every character typed-in sends the sub-panel zooming off somewhere. Plus the editor window cursor is displaced right by one space... Switching back to v0.33.2 for the time being, looking forward to v0.34.1

@paulrosenzweig paulrosenzweig added this to the 0.34.1 milestone Dec 27, 2019
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jul 6, 2021
nemanjaglumac added a commit that referenced this issue Jul 6, 2021
@nemanjaglumac
Extract repro for #11580 into a separate file
8565898
nemanjaglumac added a commit that referenced this issue Jul 6, 2021
@nemanjaglumac
[SQL filters coverage] Group reproductions (#16898)
6724855 
* Extract repro for #12228 into a separate file

* Extract repro for #15444 into a separate file

* Extract repro for #15460 into a separate file

* Extract repro for #15700 into a separate file

* Extract repro for #15981 into a separate file

* Extract repro for #16739 into a separate file

* Extract repro for #13961 into a separate file

* Extract repro for #14145 into a separate file

* Extract repro for #12581 into a separate file

* Extract repro for #14302 into a separate file

* Extract repro for #15163 into a separate file

* Extract repro for #11580 into a separate file

* Extract repro for #11480 into a separate file

* Extract repro for #9357 into a separate file
@deploysentinel deploysentinel bot mentioned this issue Dec 19, 2022
Merged
This was referenced Jan 25, 2023
Closed
Merged
This was referenced Apr 11, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Aug 10, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulrosenzweig paulrosenzweig

Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.34.1
Development

Successfully merging a pull request may close this issue.

Preserve template-tags key order metabase/metabase
5 participants
@salsakran @paulrosenzweig @flamber @nemanjaglumac @MarcGJA