Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't archive a question from the Question page #16512

Closed
kulyk opened this issue Jun 9, 2021 · 0 comments · Fixed by #16514
Closed

Can't archive a question from the Question page #16512

kulyk opened this issue Jun 9, 2021 · 0 comments · Fixed by #16514
Assignees
@kulyk
Labels
Organization/Saved Questions Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.40

Comments

@kulyk
Copy link
Member

kulyk commented Jun 9, 2021

Describe the bug
When archiving a question from the question page, it navigates you to the collection as expected, but the item isn't achieved and there is a message saying "Unarchived the item"

To Reproduce

  1. Open any question
  2. Click the pencil icon near the question's name
  3. Click archive
  4. Confirm the archive
  5. You're navigated to the collection page, but the question isn't achieved and there is a message saying "Unarchived the item"

Expected behavior
The item should disappear from the list and the toast message should say "Archived the item"

Demo

Screen.Recording.2021-06-09.at.12.36.58.mov

Information about your Metabase Installation:

Metabase version: latest master (commit)
Metabase hosting environment: local, master branch
Metabase internal database: H2 (default), sample dataset
@kulyk kulyk added Type:Bug Product defects .Needs Triage .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 9, 2021
@kulyk kulyk self-assigned this Jun 9, 2021
@flamber flamber added Priority:P2 Average run of the mill bug Organization/Saved Questions and removed .Needs Triage labels Jun 9, 2021
@kulyk kulyk mentioned this issue Jun 9, 2021
Merged
kulyk added a commit that referenced this issue Jun 9, 2021
@kulyk
Add repro note for #16512
d2af361
kulyk added a commit that referenced this issue Jun 9, 2021
@kulyk
Fix can't archive a question from the Question page (#16514)
7984789 
* Fix question archiving test

* Fix archiving a question

* Add repro note for #16512
@rlotun rlotun added this to the 0.40 milestone Jun 9, 2021
@deploysentinel deploysentinel bot mentioned this issue Jan 11, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 19, 2023
Merged
This was referenced Jan 30, 2023
Merged
Merged
Merged
This was referenced Feb 21, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 17, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue May 11, 2023
Merged
This was referenced Jun 14, 2023
Merged
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Aug 3, 2023
Closed
@deploysentinel deploysentinel bot mentioned this issue Aug 30, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Sep 6, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Sep 20, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Oct 16, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 3, 2023
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Organization/Saved Questions Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Fix can't archive a question from the Question page metabase/metabase
3 participants
@rlotun @flamber @kulyk