Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model becomes confusing, when Data Model column visibility is used #22521

Closed
flamber opened this issue May 8, 2022 · 2 comments · Fixed by #24882
Closed

Model becomes confusing, when Data Model column visibility is used #22521

flamber opened this issue May 8, 2022 · 2 comments · Fixed by #24882
Assignees
@calherries
Labels
.Correctness Priority:P2 Average run of the mill bug Querying/Models aka Datasets .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.45

Comments

@flamber
Copy link
Contributor

flamber commented May 8, 2022 •
edited by WiNloSt
Loading

Describe the bug
Model becomes confusing, when Data Model column visibility is used. And makes it impossible to edit metadata correctly.
Not sure if this is both BE or FE.

To Reproduce

  1. Question > Sample > Products - save as "Q1"
  2. Question > Sample > Orders - join with Saved Question "Q1" - save as "Q2"
  3. Admin > Data Model > Products > change visibility of Vendor to "Only in detail views"
  4. Turn in a Model
  5. Go back to the model > click "Edit query definition" - it looks like Vendor is included, but is not shown anywhere
    image
  6. Clicking Metadata and trying to select any of the last columns (eg. Rating) will mark the next column as selected.
    image

Addition to step 6: It seems like this can sometimes cause the metadata sidebar to become blank in some situations, but I haven't been able to reproduce that consistently (only on some of my test setups):

Screencast-2022-05-28_12.43.39.mp4

Information about your Metabase Installation:
Tested 0.42.0 thru 0.43.0

Additional context
Likely very related to #22520
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug .Correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Querying/Models aka Datasets labels May 8, 2022
This was referenced May 27, 2022
Closed
Closed
nemanjaglumac added a commit that referenced this issue Jun 3, 2022
@nemanjaglumac
Add repro for #22521
8bbab35
@nemanjaglumac nemanjaglumac mentioned this issue Jun 3, 2022
Closed
@gusaiani gusaiani mentioned this issue Aug 16, 2022
Closed
@calherries calherries self-assigned this Aug 18, 2022
@calherries calherries mentioned this issue Aug 18, 2022
Merged
@WiNloSt
Copy link
Member

WiNloSt commented Aug 19, 2022 •
edited
Loading

@flamber Not sure what I did wrong, but I need to swap steps 3 and 4 on the repro steps to reproduce this bug. Maybe the repro steps could need an update?

@flamber
Copy link
Contributor Author

flamber commented Aug 19, 2022

@WiNloSt This issue has had several other problems, which were difficult to reproduce, and there has been a lot of changes since the issue was created.

@flamber flamber added this to the 0.45 milestone Aug 22, 2022
@flamber flamber mentioned this issue Sep 15, 2022
Closed
@flamber flamber mentioned this issue Sep 28, 2022
Closed
@deploysentinel deploysentinel bot mentioned this issue Dec 6, 2022
Closed
1 task
@deploysentinel deploysentinel bot mentioned this issue Jan 9, 2023
Closed
1 task
@deploysentinel deploysentinel bot mentioned this issue Jan 30, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 10, 2023
Closed
This was referenced Mar 15, 2023
Merged
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue May 30, 2023
Closed
This was referenced Jul 27, 2023
Closed
Closed
Closed
@deploysentinel deploysentinel bot mentioned this issue Oct 20, 2023
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calherries calherries

Labels
.Correctness Priority:P2 Average run of the mill bug Querying/Models aka Datasets .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.45
Development

Successfully merging a pull request may close this issue.

Show all "details-only" columns in the metadata tab of the DatasetEditor metabase/metabase
3 participants
@flamber @WiNloSt @calherries